[Bug 18677] New: issue_id is not added to accountlines for lost item fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Bug ID: 18677 Summary: issue_id is not added to accountlines for lost item fees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Database |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74022&action=edit Bug 18677: issue_id is not added to accountlines for lost item fees Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 74022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74022 Bug 18677: issue_id is not added to accountlines for lost item fees Review of attachment 74022: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18677&attachment=74022) ----------------------------------------------------------------- ::: t/db_dependent/Accounts.t @@ -528,2 @@
$lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' }); - $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
This seems like an accidental deletion. @@ -599,3 @@
$lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' }); $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' }); - is( $lostfine->amount, "6.120000" , "Lost fine equals replacementcost when pref on and default set");
This seems like an accidental deletion. Also, I prefer the more format agnostic +0 forced typecast. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 74022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74022 Bug 18677: issue_id is not added to accountlines for lost item fees Review of attachment 74022: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18677&attachment=74022) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +3633,5 @@
defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!"; # zero is OK, check defined } if (C4::Context->preference('WhenLostChargeReplacementFee')){ + my $checkout = Koha::Checkouts->find({ itemnumber => $itemnumber }); + C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $checkout->id, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}");
There is no test code which triggers this change as far as I can tell. Please include a test which does. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74022|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74165&action=edit Bug 18677: issue_id is not added to accountlines for lost item fees Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen@inlibro.com --- Comment #5 from Maksim Sen <maksim.sen@inlibro.com> --- I got this error while trying to do the test: t/db_dependent/Accounts.t .. 18/25 DBD::mysql::st execute failed: Duplicate entry '2147483647' for key 'PRIMARY' [for Statement "INSERT INTO `biblio` ( `abstract`, `author`, `copyrightdate`, `datecreated`, `frameworkcode`, `notes`, `serial`, `seriestitle`, `timestamp`, `title`, `unititle`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='SqTkFqA', 1='Hl8u8G9qy', 2=26992, 3='2018-04-13', 4='A1mS', 5='MrVzEx', 6=9, 7='ya33U7dw6_', 8='2018-04-13 18:42:47', 9='cyTtFLH', 10='twGKLqjb'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834. # No tests run! # Failed test 'No tests run for subtest "More Koha::Account::pay tests"' # at t/db_dependent/Accounts.t line 400. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '2147483647' for key 'PRIMARY' at /inlibro/git/koha-master-dev-inlibro/t/lib/TestBuilder.pm line 288 # Looks like your test exited with 255 just after 20. t/db_dependent/Accounts.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 6/25 subtests Test Summary Report ------------------- t/db_dependent/Accounts.t (Wstat: 65280 Tests: 20 Failed: 1) Failed test: 20 Non-zero exit status: 255 Parse errors: Bad plan. You planned 25 tests but ran 20. Files=1, Tests=20, 6 wallclock secs ( 0.04 usr 0.00 sys + 2.54 cusr 0.16 csys = 2.74 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- While I think Maksim Sim's error is bad data, I'll mark this Failed QA due to comments #2 and #3. #3 is a request for test coverage of a code change in a C4 library. Given how tests make code changes easier to check and our current RM, please provide them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #6)
While I think Maksim Sim's error is bad data, I'll mark this Failed QA due to comments #2 and #3. #3 is a request for test coverage of a code change in a C4 library. Given how tests make code changes easier to check and our current RM, please provide them.
#2 was fixed with the last patch uploaded. For #3 there is already a unit test added in Circulation.t in this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #6)
While I think Maksim Sim's error is bad data, I'll mark this Failed QA due to comments #2 and #3. #3 is a request for test coverage of a code change in a C4 library. Given how tests make code changes easier to check and our current RM, please provide them.
#2 was fixed with the last patch uploaded. For #3 there is already a unit test added in Circulation.t in this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I get test errors after trying to resolve merge conflicts when applying this.. requesting a rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74165|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81133&action=edit Bug 18677: issue_id is not added to accountlines for lost item fees Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81133|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81732&action=edit Bug 18677: issue_id is not added to accountlines for lost item fees Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well for me: Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think there is something wrong. Why do you pass the issue_id to chargelostitem when we can guess it from the itemnumber given? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 81732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81732 Bug 18677: issue_id is not added to accountlines for lost item fees Review of attachment 81732: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18677&attachment=81732) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +99,4 @@
sub chargelostitem{ my $dbh = C4::Context->dbh(); + my ($borrowernumber, $itemnumber, $issue_id, $amount, $description) = @_;
change of parameters needs to make sure all places are changed. I can't get my Windows VM up, and I don't have time to boot my Ubuntu machine. Could someone please check C4::Overdues? I think this change might break there, which is why JD's comment about not passing it, and looking it up here makes sense to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Changing from Signed off to In Discussion so that questions will be addressed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is only 1 call, from C4::Circulation::LostItem, the occurrence in C4::Overdues is part of a comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #16)
There is only 1 call, from C4::Circulation::LostItem, the occurrence in C4::Overdues is part of a comment
So it is. Still, I thought the general thrust of development was to move towards the Koha namespace, and if not, perhaps hashref the parameter list, so that at least it gets closer to our coding guidelines. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_shou... Also, that comment in C4::Overdues makes me wonder about a tiny refactor / move into the Koha name space. But perhaps that is beyond the scope of this. Changing the parameter to a hashref should be a simple enough fix. Though, I do think putting the lookup in the function, rather than in the calling function, and thus avoid the need to change the parameter list, is probably better. Less files affected. Less is more. It's not like chargelostitems is called for the same thing multiple times, is it? If it is, the external look up and hashref parameter is probably preferred. After all, we don't want to slow things down either. To summarize: if there are no speed issues caused by a double call, then moving the look up into the function is the preferred fix. If there is a speed issue, then hashref'ing the parameter list and leaving it external is preferred. Just my take on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|kyle@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Working on an alternative patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81823&action=edit Bug 18677: Make the tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81824&action=edit Bug 18677: Remove new issue_id param from charlostitem We have the itemnumber no need to pass the issue_id, we can retrieve it from chargelostitem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |kyle@bywatersolutions.com |ommunity.org | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #18)
Working on an alternative patch.
I have attached 2 follow-ups, back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81732|0 |1 is obsolete| | Attachment #81823|0 |1 is obsolete| | Attachment #81824|0 |1 is obsolete| | --- Comment #22 from Michal Denar <black23@gmail.com> --- Created attachment 81976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81976&action=edit Bug 18677: issue_id is not added to accountlines for lost item fees Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #23 from Michal Denar <black23@gmail.com> --- Created attachment 81977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81977&action=edit Bug 18677: Make the tests pass Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #24 from Michal Denar <black23@gmail.com> --- Created attachment 81978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81978&action=edit Bug 18677: Remove new issue_id param from charlostitem We have the itemnumber no need to pass the issue_id, we can retrieve it from chargelostitem Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21848 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Bit distracted by unac_string. See 21848 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81976|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82386&action=edit Bug 18677: issue_id is not added to accountlines for lost item fees Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michal Denar <black23@gmail.com> [EDIT:] Patch should have increased the number of tests obviously. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81977|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82387&action=edit Bug 18677: Make the tests pass Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81978|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82388&action=edit Bug 18677: Remove new issue_id param from charlostitem We have the itemnumber no need to pass the issue_id, we can retrieve it from chargelostitem Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82389&action=edit Bug 18677: (QA follow-up) Trivial fixes to Chargelostitem.t Kind of funny that we did not touch this test here. But it passed! Trivial fixes: [1] Typo precessfee [2] Typo the linked [3] Add rollback Test plan: Run t/db_dependent/Circulation/Chargelostitem.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Database |Circulation QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #32 from Jesse Maseto <jesse@bywatersolutions.com> --- Back ported to 18.05. Will be in 18.05.07 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #33 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org