https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159627&action=edit Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options This patch adds a missing option to the CollapseFieldsPatronAddForm system preference so that the "Non-patron guarantor" section can be collapsed by default. To test, apply the patch and go to Administration -> System preferences. - Search for CollapseFieldsPatronAddForm. - In the dropdown of options you should see an entry for "Non-patron guarantor." - Click "Select all" and save your changes. - Go to Patrons -> New patron and choose a patron category which can have a guarantor (for example J - Juvenile) - The patron entry page should load with all sections collapsed, including the Non-patron guarantor section. - Uncheck all options in the CollapseFieldsPatronAddForm preference and return to the patron entry form. All sections should now appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- For me, this worked except for under the "Add patron (Kid) heading: it only shows [] Show collapsed fields (without No-patron guarantor). For example, if I ticked Non-patron guarantor and Patron guarantor, this shows under the heading: [] Show collapsed fields: Guarantor information | (As an aside, I don't think the display under the heading is that great, but I have no suggestions...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159627|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160034&action=edit Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options This patch adds a missing option to the CollapseFieldsPatronAddForm system preference so that the "Non-patron guarantor" section can be collapsed by default. To test, apply the patch and go to Administration -> System preferences. - Search for CollapseFieldsPatronAddForm. - In the dropdown of options you should see an entry for "Non-patron guarantor." - Click "Select all" and save your changes. - Go to Patrons -> New patron and choose a patron category which can have a guarantor (for example J - Juvenile) - The patron entry page should load with all sections collapsed, including the Non-patron guarantor section. - Uncheck all options in the CollapseFieldsPatronAddForm preference and return to the patron entry form. All sections should now appear. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds Non-patron release notes| |guarantor as an option to | |the | |CollapseFieldsPatronAddForm | |system preference - this | |section can now be | |collapsed on the patron | |form. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes.