https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- To Test: 1) Set maxoutstanding to blank 2) give yourself $0.50 in fines 3) go to opac, confirm you're blocked from placing holds 4) set maxoutstanding=1 5) confirm you are no longer blocked from placing holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103377&action=edit Bug 25220: maxoutstanding ignored if null in opac-reserve.pl To Test: 1) set maxoutstanding to empty 2) give yourself a fine of $1 3) try to place a hold on the opac 4) confirm you cannot place hold 5) apply patch, restart_all 6) reload opac 7) confirm hold is allowed 8) set maxoutstanding to $2 9) confirm hold is now blocked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103388&action=edit Bug 25220: atomicupdate to maintain behavior of existing installs To test: 1) on an existing install, set maxoutstanding to null 2) apply patch 3) confirm maxoutstanding is now set to zero -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104507&action=edit Bug 25220: make maxoutstanding set to null not give warning on opac-user.pl To test: 1) set maxoutstanding to empty 2) give yourself $1 in fine 3) go to your account on OPAC 4) confirm you have message that holds are blocked 5) apply patch, restart_all 6) reload OPAC 7) confirm message is gone 8) set maxoutstanding to $2 9) reload opac, confirm message is back Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- C4/SIP/ILS/Patron.pm: && $self->fee_amount > C4::Context->preference("maxoutstanding") ); circ/offline.pl:$template->{'VARS'}->{'maxoutstanding'} = circ/offline.pl: C4::Context->preference('maxoutstanding') || 0; installer/data/mysql/atomicupdate/bug_25220.perl: $dbh->do( "UPDATE systempreferences set value=0 where variable='maxoutstanding' and (value='' or value is null)" ); installer/data/mysql/atomicupdate/bug_25220.perl: NewVersion( $DBversion, 25220, "maxoutstanding should be disabled by a null value"); installer/data/mysql/sysprefs.sql:('maxoutstanding','5','','maximum amount withstanding to be able make holds','Integer'), koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: - pref: maxoutstanding koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: if (parseInt(patron.fine) > [% maxoutstanding | html %]) { koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %] koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: [% IF ( expiry || diffbranch || patron.is_debarred || ( amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') ) ) %] koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %] opac/opac-reserve.pl:my $maxoutstanding = C4::Context->preference("maxoutstanding"); opac/opac-reserve.pl:$maxoutstanding = undef unless looks_like_number($maxoutstanding); opac/opac-reserve.pl:$template->param( noreserve => 1 ) unless $maxoutstanding; opac/opac-reserve.pl:if ( $amountoutstanding && defined($maxoutstanding) && ($amountoutstanding > $maxoutstanding) ) { opac/opac-user.pl:my $maxoutstanding = C4::Context->preference('maxoutstanding'); opac/opac-user.pl:$maxoutstanding = undef unless looks_like_number ( $maxoutstanding ); opac/opac-user.pl:if ( $amountoutstanding && defined($maxoutstanding) && ( $amountoutstanding > $maxoutstanding ) ){ Are you sure that you only needed to change opac-reserve and opac-user ? If I am looking at this git grep, I wouldnt. Also note that the test Koha.Pref( ) && a > b, looks a bit more elegant, although it could trigger warnings on non-numerical comparison if you wrote "abc" in maxoutstanding. But who would? + $dbh->do( "UPDATE systempreferences set value=0 where variable='maxoutstanding' and (value='' or value is null)" ); This does not look good. Value is a text field. You mean '0'? :) I think we dont need this change. And also you dont correct 'abc'? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.