https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #1 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63496&action=edit Bug 18618: Mana - Add scripts to send readings - There are 2 differents scripts: misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't enabled - Both of scripts anonymize the datas and send them to mana. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Summary|Mana - Add reading |Mana - Add reading |suggestions (crontab - |suggestions (crontab and |scripts) |scripts for Koha) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #4 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64531&action=edit Bug 18618: Add a pagination for suggestions *** Suggestions are now sent from Mana as follows - Koha requests the first 20 suggestions - It processes them and estimates how much it will need to get all suggestions - It requests Mana the number of suggestions needed - It repeats the 3 first steps until (1) Mana doesn't have suggestions anymore (2) It got 10 suggestions to display *** Koha interface is a bit more verbose while searching (just a bit). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #5 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64960&action=edit Bug 18618: Correct Plack issues Split one command line into two in order to be accepted by Plack -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63496|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65066&action=edit Bug 18618: Mana - Add scripts to send readings - There are 2 differents scripts: misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't enabled - Both of scripts anonymize the datas and send them to mana. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63497|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65068&action=edit Bug 18618: Mana - Add reading suggestion There is now a module to get suggestions from Mana. - It is activated by default on Mana. - When you browse on a notice, there is now a tab called "Suggestions" - On click on the tab, it will check in the database if it has suggestions. - Else, it will ask to Mana for suggestions and will store in the database. - The suggestions are stored in the NEW table reading_pairs - Implement new dbix objets: Reading_suggestion and Reading_suggestions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64960|0 |1 is obsolete| | --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65070&action=edit Bug 18618: Correct Plack issues Split one command line into two in order to be accepted by Plack Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |BLOCKED --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- BLOCKED by failed base patch bug 17047 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65067|0 |1 is obsolete| | --- Comment #16 from marion.durand@biblibre.com --- Created attachment 130706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130706&action=edit Bug 18618: Mana - Add scripts to send readings - There are 2 differents scripts: misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't enabled - Both of scripts anonymize the datas and send them to mana. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65069|0 |1 is obsolete| | --- Comment #18 from marion.durand@biblibre.com --- Created attachment 130708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130708&action=edit Bug 18618: Add a pagination for suggestions *** Suggestions are now sent from Mana as follows - Koha requests the first 20 suggestions - It processes them and estimates how much it will need to get all suggestions - It requests Mana the number of suggestions needed - It repeats the 3 first steps until (1) Mana doesn't have suggestions anymore (2) It got 10 suggestions to display *** Koha interface is a bit more verbose while searching (just a bit). Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #20 from marion.durand@biblibre.com --- Created attachment 130710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130710&action=edit Bug 18618: Rebase modification Remove mana_send_pairs_without_mana.pl This script was here for testing purpose and is not usefull anymore Fix name issues (some function have been renamed) Fix a compilation issues (redeclared variable) Remove an unused variable Remove an extra % in an sql request Fix display problem when getting info from mana When getting info from mana the biblios array contain blessed references but the template don't deal with that properly. It work fine whe koha is getting info from it's interne database because biblios array contain unblessed references. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #22 from marion.durand@biblibre.com --- Created attachment 130712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130712&action=edit Bug 18618: Add a better support for different id types Add a better support for ISMN, ISRN, ISRC and UPC Add normalization function for some of these ids. When sending pairs to mana and when getting suggestions these ids are now taken into account correctly. Documents with multiple identifier were causing various trouble. It was needed to add functions to normalize all ids This patch add the possibility to: - create pairs with documents with multiple ids (all the possible pairs will be created) - get suggestion for a document with multiple ids - display correctly the document when the suggested document has multiple ids -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #24 from marion.durand@biblibre.com --- Created attachment 130714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130714&action=edit Bug 18618 : refacto to allow unit test and add unit test Re-write pairs extraction script to use testable function Re-write getSuggestion script to use testable function Add unit test for normalizaation functions Add unit test for pairs extractions function Add unit test for getSuggestion function Fix many small problems found while writing unit test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED CC| |marion.durand@biblibre.com --- Comment #26 from marion.durand@biblibre.com --- This feature adds reading suggestion for Koha using Mana. It is based on pairs of document borrowed by the same patron. (If two document are often borrowed together, it is probably interesting to suggest the second while looking for suggestion linked with the first) This feature is divided in two part : - One part for extracting pair to feed Mana database - One part for getting and displaying suggestions on the OPAC Testing is only possible with the test server of Mana because mana-side code is not integrated yet (you can find it here https://gitlab.com/koha-community/koha-mana/-/merge_requests/13) We will let you know here when it's ready. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130706|0 |1 is obsolete| | --- Comment #27 from marion.durand@biblibre.com --- Created attachment 130735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130735&action=edit Bug 18618: Mana - Add scripts to send readings - There are 2 differents scripts: misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't enabled - Both of scripts anonymize the datas and send them to mana. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130708|0 |1 is obsolete| | --- Comment #29 from marion.durand@biblibre.com --- Created attachment 130737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130737&action=edit Bug 18618: Add a pagination for suggestions *** Suggestions are now sent from Mana as follows - Koha requests the first 20 suggestions - It processes them and estimates how much it will need to get all suggestions - It requests Mana the number of suggestions needed - It repeats the 3 first steps until (1) Mana doesn't have suggestions anymore (2) It got 10 suggestions to display *** Koha interface is a bit more verbose while searching (just a bit). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130710|0 |1 is obsolete| | --- Comment #31 from marion.durand@biblibre.com --- Created attachment 130739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130739&action=edit Bug 18618: Rebase modification Remove mana_send_pairs_without_mana.pl This script was here for testing purpose and is not usefull anymore Fix name issues (some function have been renamed) Fix a compilation issues (redeclared variable) Remove an unused variable Remove an extra % in an sql request Fix display problem when getting info from mana When getting info from mana the biblios array contain blessed references but the template don't deal with that properly. It work fine whe koha is getting info from it's interne database because biblios array contain unblessed references. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130712|0 |1 is obsolete| | --- Comment #33 from marion.durand@biblibre.com --- Created attachment 130741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130741&action=edit Bug 18618: Add a better support for different id types Add a better support for ISMN, ISRN, ISRC and UPC Add normalization function for some of these ids. When sending pairs to mana and when getting suggestions these ids are now taken into account correctly. Documents with multiple identifier were causing various trouble. It was needed to add functions to normalize all ids This patch add the possibility to: - create pairs with documents with multiple ids (all the possible pairs will be created) - get suggestion for a document with multiple ids - display correctly the document when the suggested document has multiple ids -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130714|0 |1 is obsolete| | --- Comment #35 from marion.durand@biblibre.com --- Created attachment 130743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130743&action=edit Bug 18618 : refacto to allow unit test and add unit test Re-write pairs extraction script to use testable function Re-write getSuggestion script to use testable function Add unit test for normalizaation functions Add unit test for pairs extractions function Add unit test for getSuggestion function Fix many small problems found while writing unit test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130735|0 |1 is obsolete| | Attachment #130736|0 |1 is obsolete| | Attachment #130737|0 |1 is obsolete| | Attachment #130738|0 |1 is obsolete| | Attachment #130739|0 |1 is obsolete| | Attachment #130740|0 |1 is obsolete| | Attachment #130741|0 |1 is obsolete| | Attachment #130742|0 |1 is obsolete| | Attachment #130743|0 |1 is obsolete| | Attachment #130744|0 |1 is obsolete| | --- Comment #37 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 132690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132690&action=edit Bug 18618: Mana readings pairs - There are 2 differents scripts: misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't enabled - Both of scripts anonymize the datas and send them to mana. Bug 18618: Mana - Add reading suggestion There is now a module to get suggestions from Mana. - It is activated by default on Mana. - When you browse on a notice, there is now a tab called "Suggestions" - On click on the tab, it will check in the database if it has suggestions. - Else, it will ask to Mana for suggestions and will store in the database. - The suggestions are stored in the NEW table reading_pairs - Implement new dbix objets: Reading_suggestion and Reading_suggestions Bug 18618: Add a pagination for suggestions *** Suggestions are now sent from Mana as follows - Koha requests the first 20 suggestions - It processes them and estimates how much it will need to get all suggestions - It requests Mana the number of suggestions needed - It repeats the 3 first steps until (1) Mana doesn't have suggestions anymore (2) It got 10 suggestions to display *** Koha interface is a bit more verbose while searching (just a bit). Bug 18618: Correct Plack issues Split one command line into two in order to be accepted by Plack Bug 18618: Rebase modification Remove mana_send_pairs_without_mana.pl This script was here for testing purpose and is not usefull anymore Fix name issues (some function have been renamed) Fix a compilation issues (redeclared variable) Remove an unused variable Remove an extra % in an sql request Fix display problem when getting info from mana When getting info from mana the biblios array contain blessed references but the template don't deal with that properly. It work fine whe koha is getting info from it's interne database because biblios array contain unblessed references. Bug 18618 : Many small refacto and improvement * change duration before refresh and improve the use of $temp variable * improve SQL request for extracting pairs fix condition create pair with old_issues use placeholders * improve SQL request for getting suggestion add the possibility to look in metadata for the id * execute the script only if mana is activated * optimize imbricate foreach loop * add a max number of simultaneous issues * remove unused option Bug 18618: Add a better support for different id types Add a better support for ISMN, ISRN, ISRC and UPC Add normalization function for some of these ids. When sending pairs to mana and when getting suggestions these ids are now taken into account correctly. Documents with multiple identifier were causing various trouble. It was needed to add functions to normalize all ids This patch add the possibility to: - create pairs with documents with multiple ids (all the possible pairs will be created) - get suggestion for a document with multiple ids - display correctly the document when the suggested document has multiple ids Bug 18618: Add MARC21 support This functionnality is now working for both MARC21 and UNIMARC. Bug 18618 : refacto to allow unit test and add unit test Re-write pairs extraction script to use testable function Re-write getSuggestion script to use testable function Add unit test for normalizaation functions Add unit test for pairs extractions function Add unit test for getSuggestion function Fix many small problems found while writing unit test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- After dicsussion at the hackfest BibLibre: * Squash + clear (perltidy) patches and changes * Test the Koha patches (ie. fix it as it do not work)   DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Field 'biblionumber1' doesn't have a default value at /kohadevbox/koha/Koha/Object.pm line 170 * Make sure the PR in up-to-date on gitlab * Write release notes + doc + test plan (provide title to get relevant suggestions) * exportemail + securitytoken => Why? * Route shouldn't be ".json" Joubu: * Improve DB structure (biblionumberX) * Remove/Adjust Koha::Utils methods + Koha::Biblio->normalize_isbn, etc. * Remove useless tests * Test new Koha code with prod/old server code (to make sure we won't introduce regression when upgrading the server) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Any update on this one? -- You are receiving this mail because: You are watching all bug changes.