[Bug 8683] New: Acq: Clear button doesn't clear all item fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Priority: P5 - low Change sponsored?: --- Bug ID: 8683 Assignee: koha-bugs@lists.koha-community.org Summary: Acq: Clear button doesn't clear all item fields Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha UniqueItemFields: barcode AcqCreateItem: placing an order Autobarcode: 1, 2, 3... When you add items to a new order, the clear link doesn't work for some of the fields. It doesn't work for: - date acquired - barcode Maybe because of the plugins linked to those fields? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8425 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22896&action=edit Bug 8683: Clear button doesn't clear all item fields The clear js function parses input text, but input filled to a plugin does not contain the type attribute. Test plan: - fill the barcode field to the barcode plugin - go on the new order page - verify the barcode plugin works as before - verify the clear link clears the barcode field and all others fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22896|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 23004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23004&action=edit [SIGNED-OFF] Bug 8683: Clear button doesn't clear all item fields The clear js function parses input text, but input filled to a plugin does not contain the type attribute. Test plan: - fill the barcode field to the barcode plugin - go on the new order page - verify the barcode plugin works as before - verify the clear link clears the barcode field and all others fields. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23004|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23047&action=edit [PASSED QA] Bug 8683: Clear button doesn't clear all item fields The clear js function parses input text, but input filled to a plugin does not contain the type attribute. Test plan: - fill the barcode field to the barcode plugin - go on the new order page - verify the barcode plugin works as before - verify the clear link clears the barcode field and all others fields. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, passes all tests and QA script. Template change only. Barcode and date acquired are now also cleared with the 'clear' link. But: it only works when you enter a barcode manually currently, because the AutoBarcode functionality is broken on master (bug 11273). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org