[Bug 32023] New: Remove hr in opac-page.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Bug ID: 32023 Summary: Remove hr in opac-page.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org In a page created with the new Pages tool, there is a <hr> above the OpacNav block. This hr is not there on other OPAC pages. To test: 1. Go to Tools > Pages > New entry 2. Create a page and save 3. Copy the OPAC link 4. Go to Tools > HTML customizations > New entry 5. Create an OpacNav entry with the link to the page 6. Go to the OPAC main page --> Notice how the left navigation section looks 7. Click on the link on the left to go to the page --> an horizontal line appears above OpacNav -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146298&action=edit Bug 32023: Remove hr in OpacNav for CMS pages In a page created with the new Pages tool, there is a <hr> above the OpacNav block. This hr is not present on other OPAC pages and is removed by this patch. To test: 1. Go to Tools > Pages > New entry 2. Create a page and save 3. Copy the OPAC link 4. Go to Tools > HTML customizations > New entry 5. Create an OpacNav entry with the link to the page 6. Go to the OPAC main page --> Notice how the left navigation section looks 7. Click on the link on the left to go to the page --> an horizontal line appears above OpacNav 8. Apply patch 9. Repeat test - the horizontal line should be gone now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove hr in opac-page.tt |Remove horizontal line from | |OPAC navigation for CMS | |pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146298|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146300&action=edit Bug 32023: Remove hr in OpacNav for CMS pages In a page created with the new Pages tool, there is a <hr> above the OpacNav block. This hr is not present on other OPAC pages and is removed by this patch. To test: 1. Go to Tools > Pages > New entry 2. Create a page and save 3. Copy the OPAC link 4. Go to Tools > HTML customizations > New entry 5. Create an OpacNav entry with the link to the page 6. Go to the OPAC main page --> Notice how the left navigation section looks 7. Click on the link on the left to go to the page --> an horizontal line appears above OpacNav 8. Apply patch 9. Repeat test - the horizontal line should be gone now Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146300|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146321&action=edit Bug 32023: Remove hr in OpacNav for CMS pages In a page created with the new Pages tool, there is a <hr> above the OpacNav block. This hr is not present on other OPAC pages and is removed by this patch. To test: 1. Go to Tools > Pages > New entry 2. Create a page and save 3. Copy the OPAC link 4. Go to Tools > HTML customizations > New entry 5. Create an OpacNav entry with the link to the page 6. Go to the OPAC main page --> Notice how the left navigation section looks 7. Click on the link on the left to go to the page --> an horizontal line appears above OpacNav 8. Apply patch 9. Repeat test - the horizontal line should be gone now Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That HR was weird.. nice fix. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Bug 32023 depends on bug 15326, which changed state. Bug 15326 Summary: Add CMS feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org