[Bug 7728] New: subscription endddate is copied into subscription history histendate field during renew process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Priority: P4 Change sponsored?: --- Bug ID: 7728 Assignee: koha@univ-lyon3.fr Summary: subscription endddate is copied into subscription history histendate field during renew process QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: koha@univ-lyon3.fr Hardware: All Status: NEW Version: rel_3_6 Component: Serials Product: Koha Created attachment 8240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8240&action=edit histenddate box legend May be I missed something but even if the subscription history displays the following legend below the histenddate box: (if empty, subscription is still active) the new subscription enddate is systematically copied as histenddate during the renew process as we can see in the ReNewSubscription function (line 1332 from Serial.pm) : $query = qq| UPDATE subscriptionhistory SET histenddate=? WHERE subscriptionid=? |; $sth = $dbh->prepare($query); $sth->execute( $enddate, $subscriptionid ); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello Lyon3 We will soon renew subscriptions for next year. Can you tell me if it is still an issue? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- (In reply to mathieu saby from comment #1)
Hello Lyon3 We will soon renew subscriptions for next year. Can you tell me if it is still an issue?
Mathieu
yes it is on version 3.10.07 ,no changes. Olivier -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Olivier, what do you suggest? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Summary|subscription endddate is |Fixing subscription |copied into subscription |endddate inconsistency: |history histendate field |should be empty when the |during renew process |subscription is running --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- The Renewal of a subscription fills the subscriptionhistory.enddate field. This field is not filled when you create a subscription. It is supposed to keep track of the subscription end for ended subscription. The renewal should follow the same workflow as the creation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha@univ-lyon3.fr |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 45529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45529&action=edit Bug 7728: fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please provide tests to highlight the changes ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 beroud <isabelle.beroud@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isabelle.beroud@univ-lyon3. | |fr --- Comment #7 from beroud <isabelle.beroud@univ-lyon3.fr> --- I created a subscription, and in 'subscription-detail.pl' page, tab "Summary". No History end date was set I renewed the subscription => a date had been set I applied the patch I created another subscription I renewed it => no history end date had been set I signed-off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by beroud <isabelle.beroud@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 45776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45776&action=edit Bug 7728: fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off Signed-off-by: beroud <isabelle.beroud@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Failing QA this patch, I have to write unit tests before it can be QAed. Once I've added unit tests, I'll switch back to "signed-off" (if someone else want to write UT, feel free !) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 47303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47303&action=edit BZ 7728 adding unit test test plan: * run without the patch, the test will fail * run with the patch, the test will pass -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org