[Bug 9459] New: Use DataTables on hold ratios report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Bug ID: 9459 Summary: Use DataTables on hold ratios report page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/reserveratios.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The hold ratios report uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14788&action=edit Bug 9459 - Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14788|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 15084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15084&action=edit Bug 9459 - Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: At least the "Items" column is not correctly sorted (alpha sort: 1, 10, 3). Certainly caused by the <p> tag. + the aLengthMenu should contain 20 instead of 25. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15084|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15102&action=edit Bug 9459 [Revised] Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. Revision adds correct pagination options and natural sort for 'items needed' column. Patch now depends on Bug 9431 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431) which introduces the natural sort plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9431 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15102|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15181&action=edit Bug 9459 [Revised] Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. Revision adds correct pagination options and natural sort for 'items needed' column. Patch now depends on Bug 9431 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431) which introduces the natural sort plugin. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I spoke about the second column. I will modified my SO patch. Owen, show yourself if you disagree. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15181|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15224&action=edit Bug 9459 [Revised] Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. Revision adds correct pagination options and natural sort for 'items needed' column. Patch now depends on Bug 9431 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431) which introduces the natural sort plugin. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Apply the natural sort plugin on the first 2 columns -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I get a javascript error from this patch: Uncaught TypeError: Property 'natural-asc' of object #<Object> is not a function As a result of the Javascript error (I think), I get the following problematic display: http://screencast.com/t/k4l8TAppdWC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Jared, Yes, this patch depends on Bug 9431. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I will return the status to Passed QA, and revisit this once bug 9431 has been QAed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15224|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15704&action=edit Bug 9459 [Revised] Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. Revision adds correct pagination options and natural sort for 'items needed' column. Patch now depends on Bug 9431 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431) which introduces the natural sort plugin. Further revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15704|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15960&action=edit [SIGNED-OFF] Bug 9459 [Revised] Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. Revision adds correct pagination options and natural sort for 'items needed' column. Patch now depends on Bug 9431 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431) which introduces the natural sort plugin. Further revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: On top of Bug 9431. Sorting works. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hello Owen, Don't you think we can delete the a links in headers? Is it really relevant to keep sorting (without js) only on 1 table? (I suppose it is for the case where javascript is disabled). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- ping Owen -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Sorry I missed your comment Jonathan. Since we require JS in the staff client I don't see any reason why we need to keep the server-side sort. A separate bug could certainly be created for that. Or is there a reason to let that hold up this patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9431 |9984 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #15)
Sorry I missed your comment Jonathan. Since we require JS in the staff client I don't see any reason why we need to keep the server-side sort. A separate bug could certainly be created for that. Or is there a reason to let that hold up this patch?
No one :) I created a new bug for that (bug 9984). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9984 Depends on|9984 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Blocks|9984 | Depends on| |9984 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- replace tablesorter with DT on the hold ratios table. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15960|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17169&action=edit Bug 9459 [Revised] Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation -> Hold ratios). Confirm that table sorting works correctly. Revision adds correct pagination options and natural sort for 'items needed' column. Patch now depends on Bug 9431 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431) which introduces the natural sort plugin. Further revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: On top of Bug 9431. Sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9984 Depends on|9984 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org