[Bug 27510] New: Download the report in HTML format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Bug ID: 27510 Summary: Download the report in HTML format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: ivan.dziuba@inlibro.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.dziuba@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #1 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 115696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115696&action=edit Bug 27510: Download the report in HTML format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- TEST PLAN: 1. Apply this patch 2. Update database ./updatedatabase.pl Now we have new preference 'ReportUserCSS' where we can add style for our HTML report. 3. Go on the page - <intranet>/reports/guided_reports.pl 4. Download -> Document HTML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I don't see any changes to the template in this patch. Shouldn't there be a new menu item under the "Download" button? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115696|0 |1 is obsolete| | --- Comment #4 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 115702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115702&action=edit Bug 27510: Download the report in HTML format Bug 27510: Download the report in HTML format. Added to Download list this option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Owen Leonard from comment #3)
I don't see any changes to the template in this patch. Shouldn't there be a new menu item under the "Download" button?
Added! Thanks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Really like the idea of this. I've applied the patch on a sandbox and restarted services, but I get an error. Steps 1-2 are fine, and ReportUserCSS shows in the system preferences. When attempting step 3, the failure below shows on all of the guided_reports.pl pages: Could not compile /kohadevbox/koha/reports/guided_reports.pl: Can't locate HTML/Table.pm in @INC (you may need to install the HTML::Table module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/friday/plugins) at /kohadevbox/koha/reports/guided_reports.pl line 42. BEGIN failed--compilation aborted at /kohadevbox/koha/reports/guided_reports.pl line 42. at /usr/share/perl5/CGI/Compile.pm line 132 If it's a patch that can't be applied to a sandbox, revert the status and I'll let someone with a devbox test. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #7 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Sally from comment #6)
Really like the idea of this. I've applied the patch on a sandbox and restarted services, but I get an error.
Steps 1-2 are fine, and ReportUserCSS shows in the system preferences.
When attempting step 3, the failure below shows on all of the guided_reports.pl pages:
Could not compile /kohadevbox/koha/reports/guided_reports.pl: Can't locate HTML/Table.pm in @INC (you may need to install the HTML::Table module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/friday/plugins) at /kohadevbox/koha/reports/guided_reports.pl line 42. BEGIN failed--compilation aborted at /kohadevbox/koha/reports/guided_reports.pl line 42. at /usr/share/perl5/CGI/Compile.pm line 132
If it's a patch that can't be applied to a sandbox, revert the status and I'll let someone with a devbox test. :)
You need to install the HTML::Table module. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ivan.dziuba@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I think this looks good. I think the label for the menu item should say "HTML file" instead of "Document HTML." My only other concern is that the generated file isn't a complete HTML document... No <html>, no <body>, etc. Does that matter? The file opens fine in a browser. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #9 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Owen Leonard from comment #8)
I think this looks good. I think the label for the menu item should say "HTML file" instead of "Document HTML."
My only other concern is that the generated file isn't a complete HTML document... No <html>, no <body>, etc.
Does that matter? The file opens fine in a browser.
If that matter I can add all tags. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it would be good if the file validated :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115702|0 |1 is obsolete| | --- Comment #11 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 116079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116079&action=edit Bug 27510: Download the report in HTML format Bug 27510: Download the report in HTML format. Added to Download list this option. Bug 27510: Download the report in HTML format. The file is validated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116079|0 |1 is obsolete| | --- Comment #12 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 116091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116091&action=edit Bug 27510: Download the report in HTML format Bug 27510: Download the report in HTML format. Fix bugs with utf-8. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #13 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 116849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116849&action=edit Bug 27510: Download the report in HTML format. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116849|0 |1 is obsolete| | Attachment #116849|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116091|0 |1 is obsolete| | --- Comment #14 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 116850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116850&action=edit Bug 27510: Download the report in HTML format Bug 27510: Download the report in HTML format. Fix bugs with utf-8. Bug 27510: Download the report in HTML format. Added [% PROCESS params %] in URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- You need install the module HTML::Table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ivan Dziuba from comment #15)
You need install the module HTML::Table
Hi Ivan, I've added he dependency keyword - have you checked that this is available as package on Debian? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please also add a test plan to the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still quite like the idea of this. I think it would be helpful for staff users and others that have no access to the Reports module, but could profit from the links in an HTML export file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #19 from Magnus Enger <magnus@libriotech.no> --- It looks like HTML::Table is packaged, at least in Debian 9.13: $ sudo apt-cache policy libhtml-table-perl libhtml-table-perl: Installert: (ingen) Kandidat: 2.08a-3 Versjonstabell: 2.08a-3 500 500 http://mirrors.linode.com/debian stretch/main amd64 Packages So what is needed here? - A test plan in the commit message - To add libhtml-table-perl to Koha's dpendencies Should adding the dep be part of the patch, or is that something the RM adds? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116850|0 |1 is obsolete| | --- Comment #20 from Magnus Enger <magnus@libriotech.no> --- Created attachment 146135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146135&action=edit Bug 27510: Download the report in HTML format TEST PLAN: 1. Apply this patch 2. Update database ./updatedatabase.pl Now we have new preference 'ReportUserCSS' where we can add style for our HTML report. 3. Go on the page - <intranet>/reports/guided_reports.pl 4. Download -> Document HTML Signed-off-by: Magnus Enger <magnus@libriotech.no> I have fixed some conflicts and put in the test plan that was on Bugzilla. Feature works as advertised. HTML file can be downloaded and is a full HTML document. Formatting can be done with the syspref. Links generated in SQL carry over to the document (but links need to be absolute to work, of course.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #21 from Magnus Enger <magnus@libriotech.no> --- Created attachment 146142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146142&action=edit Bug 27510: Followup - Change "Document HTML" to "HTML file" as requested by Owen - Add HTML::Table to cpanfile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #22 from Magnus Enger <magnus@libriotech.no> --- Not sure if my followup should be one or two patches? I am also taking a chance on leaving this at "signed off". Please reset to "needs signoff" if that is thought necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Shouldn't this just use a Template Toolkit based template to generate the output instead of HTML::Table and a bunch of html embedded in a perl script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Shouldn't this just use a Template Toolkit based template to generate the output instead of HTML::Table and a bunch of html embedded in a perl script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #25 from Magnus Enger <magnus@libriotech.no> --- (In reply to Kyle M Hall from comment #24)
Shouldn't this just use a Template Toolkit based template to generate the output instead of HTML::Table and a bunch of html embedded in a perl script?
Yes, that does sound like a sensible idea. Ivan, could you find the time to redo the patch with a template for generating the table? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #26 from Magnus Enger <magnus@libriotech.no> --- Just a note that if HTML::Table is added to cpanfile, HTML::Table 2.08a will break the About page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #24)
Shouldn't this just use a Template Toolkit based template to generate the output instead of HTML::Table and a bunch of html embedded in a perl script?
Did I imagine you did this somewhere already Kyle? I'm struggling to find the bug if you did.. if so, we could close this as a duplicate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34136 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #27)
(In reply to Kyle M Hall from comment #24)
Shouldn't this just use a Template Toolkit based template to generate the output instead of HTML::Table and a bunch of html embedded in a perl script?
Did I imagine you did this somewhere already Kyle? I'm struggling to find the bug if you did.. if so, we could close this as a duplicate
Bug 34136 could definitely be used as an alternative to this though this patchset is for guided reports and mine is for SQL reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ivan.dziuba@inlibro.com |caroline.cyr-la-rose@inlibr | |o.com Assignee|ivan.dziuba@inlibro.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org