[Bug 5423] New: Deleted Patrons are no longer saved in table deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Summary: Deleted Patrons are no longer saved in table deletedborrowers Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: ASSIGNED Severity: blocker Priority: P5 Component: Database AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 There are structural differences between borrowers and deletedborrowers. - cardnumber varchar(16) vs. varchar(9) - privacy column is missing from deletedborrowers koha-error-log message after successfully(!) deleting a borrower: [Sun Nov 21 01:57:45 2010] [error] [client ::1] [Sun Nov 21 01:57:45 2010] deletemem.pl: DBD::mysql::st execute failed: Column count doesn't match value count at row 1 at /home/katrin/kohaclone/C4/Members.pm line 1610., referer: http://localhost:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=5 The data of the deleted borrower is not saved to the table deletedborrowers. I am going to send a patch to update the database and resolve the differences between the tables. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-11-21 02:04:51 UTC --- Created attachment 2777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2777 Proposed patch, written for and tested with HEAD Problem exists in 3.2 and HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-11-21 02:34:11 UTC --- Created attachment 2778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2778 Proposed patch, written for and tested with 3.2.x -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2777|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-12-06 06:54:18 UTC --- Created attachment 2802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2802 Patch for 3.2 Rebased to current HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2778|0 |1 is obsolete| | Attachment #2802|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-12-06 12:46:56 UTC --- Created attachment 2804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2804 Revised patch. Slightly revised patch for 3.2 and HEAD - signed off by Koustubha Kale. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Koustubha Kale <kmkale@anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmkale@anantcorp.com --- Comment #5 from Koustubha Kale <kmkale@anantcorp.com> 2010-12-06 12:51:21 UTC --- Works as promised. Tested with HEAD On Mon, Dec 6, 2010 at 12:58 PM, Katrin Fischer wrote:
Should also apply to 3.2.x
( Not tested with 3.2.x) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-08 10:15:50 UTC --- This bug is mentioned in: Bug 5423: Deleted Patrons are no longer saved in table deletedborrowers http://lists.koha-community.org/pipermail/koha-patches/2010-November/013084.... Bug 5423: Deleted Patrons are no longer saved in table deletedborrowers http://lists.koha-community.org/pipermail/koha-patches/2010-November/013085.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Patch Pushed --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-12 20:24:02 UTC --- Pushed to master please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-12-13 21:24:29 UTC --- Works in HEAD. Leaving bug open until pushed and tested in 3.2.1. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-12-13 21:35:08 UTC --- Applied to HEAD, fixed a small error in template, signed-off and resent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-12-13 21:35:26 UTC --- Too many tabs... ignore previous comment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2010-12-14 15:55:22 UTC --- I do have a privacy column in my deleted borrowers table (in HEAD) and I have no errors in my log on deleting a patron. Here's my table: mysql> select * from deletedborrowers; +----------------+----------------+---------+-----------+-------+------------+----------+--------------+------------+------------------+----------+-----------------+---------+---------+-------+----------------+--------+------+----------+----------+----------------+--------------+-----------+------------+--------+-----------+-----------+---------+---------+-------------+------------+--------------+--------------+------------+---------------+------+----------+-------------+------------------+--------------+-------------+---------------+--------------+-----------+----------+------+------------------+-------+----------------+----------+-------------+------------------+-------+---------------------+-------------------+--------------------+--------------------+--------------------+-------------------+-------------------+-----------------+----------------+---------+ | borrowernumber | cardnumber | surname | firstname | title | othernames | initials | streetnumber | streettype | address | address2 | city | zipcode | country | email | phone | mobile | fax | emailpro | phonepro | B_streetnumber | B_streettype | B_address | B_address2 | B_city | B_zipcode | B_country | B_email | B_phone | dateofbirth | branchcode | categorycode | dateenrolled | dateexpiry | gonenoaddress | lost | debarred | contactname | contactfirstname | contacttitle | guarantorid | borrowernotes | relationship | ethnicity | ethnotes | sex | password | flags | userid | opacnote | contactnote | sort1 | sort2 | altcontactfirstname | altcontactsurname | altcontactaddress1 | altcontactaddress2 | altcontactaddress3 | altcontactzipcode | altcontactcountry | altcontactphone | smsalertnumber | privacy | +----------------+----------------+---------+-----------+-------+------------+----------+--------------+------------+------------------+----------+-----------------+---------+---------+-------+----------------+--------+------+----------+----------+----------------+--------------+-----------+------------+--------+-----------+-----------+---------+---------+-------------+------------+--------------+--------------+------------+---------------+------+----------+-------------+------------------+--------------+-------------+---------------+--------------+-----------+----------+------+------------------+-------+----------------+----------+-------------+------------------+-------+---------------------+-------------------+--------------------+--------------------+--------------------+-------------------+-------------------+-----------------+----------------+---------+ | 37 | 23529000197047 | Charles | Lisa | | | | NULL | NULL | 5129 Library Rd. | NULL | Centerville, CA | 44262 | NULL | NULL | (212) 555-1212 | NULL | NULL | NULL | NULL | NULL | NULL | | NULL | | | NULL | | | 1982-10-14 | MPL | K | 1988-11-14 | 2020-12-31 | 0 | 0 | 0 | Alford | Jordan | NULL | 45 | | father | NULL | NULL | M | 42b29d0771f3b7ef | NULL | 23529000197047 | | | 0.26352253767058 | Y | | | | | | | NULL | | NULL | 1 | 1 row in set (0.00 sec) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2010-12-14 15:58:04 UTC --- oops we all missed that the patch has been pushed :) ignore my notes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 --- Comment #13 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-04 10:25:07 UTC --- This bug is mentioned in: Bug 5423: Deleted Patrons are no longer saved in table deletedborrowers http://lists.koha-community.org/pipermail/koha-patches/2010-December/013168.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-06 20:16:17 UTC --- Successfully tested on master and 3.2.x with fresh databases. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org