[Bug 17185] New: Staff client shows "Lists that include this title:" even if item is not in a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Bug ID: 17185 Summary: Staff client shows "Lists that include this title:" even if item is not in a list Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 54805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54805&action=edit screenshot of staff client showing the error In the staff client, the text "Lists that include this title:" is always shown, regardless of whether the item is in a list or not (please see attached screenshot). I've found a way to fix this, and will attach a patch using git bz. This is my first bug report so please be gentle :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 54830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54830&action=edit Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list In the staff client, the text "Lists that include this title:" is always shown, regardless of whether the item is in a list or not. This patch fixes that. Test plan: 1) Log in to staff client. 2) Go to biblio details view: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X Confirm that "Lists that include this title:" is shown even if the item is not in a list. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. "Lists that include this title:" is only shown for biblios that are actually in a list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54830|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 54833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54833&action=edit Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list In the staff client, the text "Lists that include this title:" is always shown, regardless of whether the item is in a list or not. This patch fixes that. Test plan: 1) Log in to staff client. 2) Go to biblio details view: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X Confirm that "Lists that include this title:" is shown even if the item is not in a list. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. "Lists that include this title:" is only shown for biblios that are actually in a list. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Only applies to non-XSLT view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master Assignee|gmcharlt@gmail.com |arouss1980@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54833|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 54834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54834&action=edit Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list In the staff client, the text "Lists that include this title:" is always shown, regardless of whether the item is in a list or not. This patch fixes that. Test plan: 1) Log in to staff client. 2) Go to biblio details view: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X Confirm that "Lists that include this title:" is shown even if the item is not in a list. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. "Lists that include this title:" is only shown for biblios that are actually in a list. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Only applies to non-XSLT view. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14544 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Andreas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org