[Bug 31020] New: PassItemMarcToXSLT only applies on results pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Bug ID: 31020 Summary: PassItemMarcToXSLT only applies on results pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 28373 added system preference PassItemMarcToXSLT is referenced is all XSLT system preferences. But it only applies on results pages. The only use in perl code is in C4::Search :
$marcrecord->delete_fields( @fields ) unless C4::Context->preference('PassItemMarcToXSLT');
I've tested by adding in all XSLT files : <strong>ITEMS <xsl:value-of select="count(marc:datafield[@tag=952])"/> </strong> Number of items only appears in OPAC and staff interface results pages. In fact only search pages get MARC record from search engine, in which items datas have been embedded for indexing. In other pages MARC record does not embed items datas. PS : Maybe it will be good to have separate preferences for OPAC and staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 [Bug 28373] Items fields not used in default XSLT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136435&action=edit Bug 31020: Fix PassItemMarcToXSLT in system preferences description Bug 28373 added system preference PassItemMarcToXSLT is referenced is all XSLT system preferences. But it only applies on results pages. The only use in perl code is in C4::Search :
$marcrecord->delete_fields( @fields ) unless C4::Context->preference('PassItemMarcToXSLT');
I've tested by adding in all XSLT files : <strong>ITEMS <xsl:value-of select="count(marc:datafield[@tag=952])"/> </strong> Number of items only appears in OPAC and staff interface results pages. In fact only search pages get MARC record from search engine, in which items datas have been embedded for indexing. In other pages MARC record does not embed items datas. This patch adds "MARC21 952, UNIMARC 995" to be explicit we talk about MARC datas not item tags build in XML recieved by XSLT. Test plan : 1) Apply patch 2) Search for PassItemMarcToXSLT in system preferencies 3) Look at description of PassItemMarcToXSLT 4) Check PassItemMarcToXSLT only apprears in OPACXSLTResultsDisplay and XSLTResultsDisplay -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136435|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 136436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136436&action=edit Bug 31020: Fix PassItemMarcToXSLT in system preferences description Bug 28373 added system preference PassItemMarcToXSLT is referenced is all XSLT system preferences. But it only applies on results pages. The only use in perl code is in C4::Search :
$marcrecord->delete_fields( @fields ) unless C4::Context->preference('PassItemMarcToXSLT');
I've tested by adding in all XSLT files : <strong>ITEMS <xsl:value-of select="count(marc:datafield[@tag=952])"/> </strong> Number of items only appears in OPAC and staff interface results pages. In fact only search pages get MARC record from search engine, in which items datas have been embedded for indexing. In other pages MARC record does not embed items datas. This patch adds "MARC21 952, UNIMARC 995" to be explicit we talk about MARC datas not item tags build in XML recieved by XSLT. Test plan : 1) Apply patch 2) Search for PassItemMarcToXSLT in system preferencies 3) Look at description of PassItemMarcToXSLT 4) Check PassItemMarcToXSLT only apprears in OPACXSLTResultsDisplay and XSLTResultsDisplay Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the note about release notes| |the PassItemMarcToXSLT | |system preference so that | |it is only shown for the | |OPACXSLTResultsDisplay and | |XSLTResultsDisplay system | |preferences - it was | |appearing in all XSLT | |system preferences, when it | |only applies for results | |pages. (The note is removed | |from OPACXSLTListsDisplay, | |XSLTListsDisplay, | |OPACXSLTDetailsDisplay, and | |XSLTDetailsDisplay system | |preferences.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136436|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 137592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137592&action=edit Bug 31020: Fix PassItemMarcToXSLT in system preferences description Bug 28373 added system preference PassItemMarcToXSLT is referenced is all XSLT system preferences. But it only applies on results pages. The only use in perl code is in C4::Search :
$marcrecord->delete_fields( @fields ) unless C4::Context->preference('PassItemMarcToXSLT');
I've tested by adding in all XSLT files : <strong>ITEMS <xsl:value-of select="count(marc:datafield[@tag=952])"/> </strong> Number of items only appears in OPAC and staff interface results pages. In fact only search pages get MARC record from search engine, in which items datas have been embedded for indexing. In other pages MARC record does not embed items datas. This patch adds "MARC21 952, UNIMARC 995" to be explicit we talk about MARC datas not item tags build in XML recieved by XSLT. Test plan : 1) Apply patch 2) Search for PassItemMarcToXSLT in system preferencies 3) Look at description of PassItemMarcToXSLT 4) Check PassItemMarcToXSLT only apprears in OPACXSLTResultsDisplay and XSLTResultsDisplay Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org