[Bug 21001] New: OpenLibrary book covers broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Bug ID: 21001 Summary: OpenLibrary book covers broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org OpenLibrary book covers don't appear on the search results or detail page in the OPAC. The console shows an error, "SyntaxError: missing ) after argument list books:1:16246" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I suspect a bug on their side: The answer of: https://openlibrary.org/api/books?bibkeys=ISBN%3A067002662X%2CISBN%3A1847727808%2CISBN%3A1780335792&callback=KOHA.OpenLibrary.olCallBack&jscmd=data is: KOHA.OpenLibrary.olCallBack(KOHA.OpenLibrary.olCallBack({"ISBN:067002662X": {"publish_date": "2013", [SKIP] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://github.com/internetarchive/openlibrary/issues/1014 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver.behnke@aei.mpg.de --- Comment #3 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- What is the expected answer? Is this a matter of JSON vs. JS or is this about the repeated "KOHA.OpenLibrary.olCallBack" in the answer? The latter isn't the case anymore so I wonder what's wrong as still doesn't work. Cheers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 --- Comment #4 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- I stand corrected: I got rid of the duplication by adding "format=json" as additional query parameter. So that's a possible fix if the upstream change isn't a regression. Cheers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77752&action=edit Bug 21001: Add missing format=json to openlibrary calls See https://github.com/internetarchive/openlibrary/issues/1014 Test plan: Turn on OpenLibraryCovers and OpenLibrarySearch Do a search at the OPAC You should see the covers from OpenLibrary as well as the "Searching Open Library... " and "Found XXX results in OpenLibrary collection" info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 --- Comment #6 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi Jonathan, I'm not sure my workaround should become a solution just yet. For the time being I consider this to be an upstream API bug. So until that's cleared up upstream we probably should refrain from adjusting our query. The point being that the API docs at https://openlibrary.org/dev/docs/api/books clearly state that "callback" only makes sense in conjunction with "format=javascript" (the default), not "format=json". So either their current API or its documentation are buggy and they got to fix one of those. Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Olivier, yes you are right. I wanted to provide a patch for people who wanted to patch their installation locally. It should not be pushed until the situation has been clarified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 --- Comment #8 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi guys, the issue was fixed upstream and I can confirm that covers do appear again after I reverted my local patch. I'd say this ticket can be closed, ideally after someone else confirmed the fix independently. Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks, looks good on my side too. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org