https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Got the list using % grep --files-without-match "use Koha::DateUtils.*dt_from_string" `git grep dt_from_string|cut -d':' -f1|sort|uniq` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There was no test plan... Should these files be updated as well? debian/templates/plack.psgi:use Koha::DateUtils; t/db_dependent/Circulation/IsItemIssued.t:use Koha::DateUtils; t/db_dependent/Items.t:use Koha::DateUtils; t/db_dependent/Koha/SearchEngine/Indexer.t:use Koha::DateUtils; t/db_dependent/Koha/Template/Plugin/TablesSettings.t:use Koha::DateUtils; t/db_dependent/Log.t:use Koha::DateUtils; t/db_dependent/SIP/ILS.t:use Koha::DateUtils; t/db_dependent/Search/History.t:use_ok('Koha::DateUtils'); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #5)

There was no test plan...

It's impossible to provide a full test plan for this kind of patches. If the QA script passes it's already a good step for this one, as the compilation will be checked.

Should these files be updated as well?

t/db_dependent/Circulation/IsItemIssued.t:use Koha::DateUtils; t/db_dependent/Items.t:use Koha::DateUtils; t/db_dependent/Koha/SearchEngine/Indexer.t:use Koha::DateUtils; t/db_dependent/Koha/Template/Plugin/TablesSettings.t:use Koha::DateUtils; t/db_dependent/Log.t:use Koha::DateUtils; t/db_dependent/SIP/ILS.t:use Koha::DateUtils; t/db_dependent/Search/History.t:use_ok('Koha::DateUtils');

We can remove the use statement as it's not used.

debian/templates/plack.psgi:use Koha::DateUtils;

I don't know about this one, we preload it but without the import. I prefer to keep it like that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124870|0 |1 is obsolete| | Attachment #125686|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125857&action=edit Bug 28931: Use EXPORT_OK from Koha::DateUtils It has been missed on bug 17600. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Adjusted commit title. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Bug 28931 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.