[Bug 33888] New: Overdue fines not displayed branchoverdues.pl error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Bug ID: 33888 Summary: Overdue fines not displayed branchoverdues.pl error 500 Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cacho@genac.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If there are no overdue items with fines, the report works, but if there are overdues with fines, they won't display, the script returns a 500 error, and the log records this: [Fri Jun 02 12:35:22.463020 2023] [cgi:error] [pid 8954] [client 192.168.1.1:47406] AH01215: Template process failed: undef error - : filter not found at /usr/share/koha/lib/C4/Templates.pm line 127.: /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl, referer: http://bibliotecacho-intra.locales/cgi-bin/koha/circ/circulation-home.pl [Fri Jun 02 12:35:22.527939 2023] [cgi:error] [pid 8954] [client 192.168.1.1:47406] End of script output before headers: branchoverdues.pl, referer: http://bibliotecacho-intra.locales/cgi-bin/koha/circ/circulation-home.pl This happens for 23.05 too. I tested this with a new install, english only, from debian packages. Also happened when updating a couple of unrelated servers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Version|22.05 |unspecified Status|NEW |Needs Signoff Severity|normal |critical CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152077&action=edit Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates Bug 22375 added use of KohaDates without the USE statement. Test plan: Make sure you have overdues and go to circ/branchoverdues.pl Without this patch you get a 500 Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127 With this patch applied you can see the overdue list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- No other occurrences apparently, the following command return only include files grep -l '$KohaDates' **/*.tt **/*.inc | xargs grep -L 'USE KohaDates' Ideally we should have the USE statement in include files as well, and add a test to catch those problems for KohaDates, raw, Price, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152077|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 152085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152085&action=edit Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates Bug 22375 added use of KohaDates without the USE statement. Test plan: Make sure you have overdues and go to circ/branchoverdues.pl Without this patch you get a 500 Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127 With this patch applied you can see the overdue list Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the 'Circulation release notes| |> Overdues > Overdues with | |fines' listing so that it | |lists overdue items where | |there are fines, instead of | |generating an error. --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To generate overdues with fines: . set finesMode system preference to 'Calculate and charge' . configure the Circulation and fine rules so that fines will be charged, I set: . Fine amount: 5 . Fine charging interval: 2 . checkout some items to a patron - set the due date in the past . run the misc/cronjobs/fines.pl script to calculate fines (I used fines.pl -v -m 10) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #5 from Hector Gonzalez <cacho@genac.org> --- The patch fixes the problem in our servers, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22375 Keywords| |rel_22_11_candidate, | |rel_23_05_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 [Bug 22375] Due dates should be formatted consistently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152085|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152202&action=edit Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates Bug 22375 added use of KohaDates without the USE statement. Test plan: Make sure you have overdues and go to circ/branchoverdues.pl Without this patch you get a 500 Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127 With this patch applied you can see the overdue list Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overdue fines not displayed |Overdues with fines report |branchoverdues.pl error 500 |displays error 500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Bug 33888 depends on bug 22375, which changed state. Bug 22375 Summary: Due dates should be formatted consistently https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can this please be backported for next bugfix releas? No strings! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #8)
Can this please be backported for next bugfix releas? No strings!
I second Katrin, can this please be backported to 22.11.xx? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Laura Escamilla from comment #9)
(In reply to Katrin Fischer from comment #8)
Can this please be backported for next bugfix releas? No strings!
I second Katrin, can this please be backported to 22.11.xx?
Indeed it is need for 22.11.x since it contains Bug 22375. Now that I have backported to 23.05 it will come down to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #11)
(In reply to Laura Escamilla from comment #9)
(In reply to Katrin Fischer from comment #8)
Can this please be backported for next bugfix releas? No strings!
I second Katrin, can this please be backported to 22.11.xx?
Indeed it is need for 22.11.x since it contains Bug 22375. Now that I have backported to 23.05 it will come down to 22.11.x
Doesn't look like it was part of v22.11.07. Does that mean it'll be part of v22.11.08 at the end of July? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yup, it'll make it to .08.. We'd already rolled .07 when this hit 23.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org