[Bug 6139] New: Automatic incrementation of call number does not work if given prefix contains a '
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 Bug #: 6139 Summary: Automatic incrementation of call number does not work if given prefix contains a ' Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: sophie.meynieux@biblibre.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2011-04-08 09:38:16 UTC --- For example, create an item with call number SHS-PERC'ESP -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 --- Comment #2 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2011-04-08 10:18:14 UTC --- Created attachment 3831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3831 Fix automatic incrementation if prefix contains ' and also fix incrementation if it is the first number with this prefix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #3 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2011-04-08 10:24:53 UTC --- To test, you should have a framework with callnumber field connected to callnumber.pl plugin Then you try to create an item on a biblio with this framework. In field callnumber you enter the prefix and then click on ... Without the patch if your prefix contains a ' (like SHS-PERC'ESP for example), this does nothing. With the patch, callnumber is automatically updated with te next value corresponding (SHS-PERC'ESP 549 for example) If you enter a new prefix (never used before) without the patch, callnumber is cleared. With the patch it returns the first callnumber for this prefix (WXZ 1 for example) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3831|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-10 11:56:46 UTC --- Created attachment 4928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4928 proposed patch (passed QA) QA comment * small patch * good explanations to reproduce the problem and the fixed behaviour passed QA earned easily. Just one note: - return => $code, + return => $code => this change was useless, it's perfectly valid to have something like $template->param (xxx => xxx,); in Perl (with a trailing comma at the end) But is not wrong to have none, so won't refuse passed QA just for this ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-14 08:29:19 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org