http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 17900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17900&action=edit proposed patch #1 [MT11604] Like in bug 9215, the new strings begin with a capital letter. It's thus possible to check the new behaviour even if you stay in English mode. The five fields showed in the screenshot use now string in templates which can be translated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Made for Rennes 2. Thank you Adrien & Chris ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17917|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18020&action=edit Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Not only does this make the strings translatable it makes the template a lot easier to read Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Clear changes to template! Table design still refers to value 'use_template' for overlay_action. This seems to be obsolete? Followup for table needed? record_lis.status: you do not include 'error' ,'staged','items_reverted'? See table design. If needed, please send a followup. record_lis.overlay_status: Same for 'auto_match','manual_match'? It seems that Stage-marc-import does not correctly save my actions. When I choose Ignore, manage-marc-import comes back with Add. If I change the values on manage-marc-import, it looks okay though. So this is outside scope of this report. Can you confirm this error? Although this may still need some attention, we are improving the template. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Adrien's patch is fine as far as it goes, but I've attached a follow-up that addresses Marcel's observation about the 'auto_match' overlay status and 'staged' and 'error' record status -- for simple stuff like this, I prefer to push a patch or a patch series that completely addresses the problem. I've intentionally not supplied anything for the 'manual_match' and 'items_reverted' statuses, as there's at present no code that will set them. Hopefully this can be fixed in time for 3.14. For the record, the intention was that 'manual_match' would signify that a user had performed a search and manually identified a matching bib record, while 'items_reverted' would signify an operation that would remove items added during a previous commit without reverting the bib record as well. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18257|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19496&action=edit bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19627&action=edit [PASSED QA] Bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. New strings are parsed into the po files: "%s Always add items %s Add items only if matching bib was found %s Add items only if no matching bib was found %s Ignore items %s %s %s %s " "%s No match %s Match applied %s Match found %s %s %s " -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Adrien! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11845 -- You are receiving this mail because: You are watching all bug changes.