[Bug 34377] New: accountline-details.pl does not show related transaction information for credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Bug ID: 34377 Summary: accountline-details.pl does not show related transaction information for credits Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. From the patron Accounting tab > "Create manual credit" 2. After doing so visit accountline-details.pl for that particular transaction. 3. Notice that there is no related transaction information. 4. It would be nice if this displayed, especially the managing Librarian bit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- My mistake. Where the managing librarian is needed is in the Details of debit/credit table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|accountline-details.pl does |accountline-details.pl does |not show related |not show managing librarian |transaction information for |info for credits/debits |credits | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155345&action=edit Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- You construct the name display here manually.. don't we have an include for that to ensure consistency? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155345|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155379&action=edit Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155380&action=edit Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I signed off and added a follow-up to convert to using the aforementioned include. I'm confused by that include.. it requires `hide_patron_infos_if_needed => 1` is passed to allow a link to be created. In this case, we're looking at a librarian, I sort of feel like we should be able to override the hide but that would nuke the link which would be a regression I believe. Anywho.. it's looking good to me now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #6)
I signed off and added a follow-up to convert to using the aforementioned include.
I'm confused by that include.. it requires `hide_patron_infos_if_needed => 1` is passed to allow a link to be created. In this case, we're looking at a librarian, I sort of feel like we should be able to override the hide but that would nuke the link which would be a regression I believe.
Anywho.. it's looking good to me now.
Thank you, Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155379|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157234&action=edit Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155380|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157235&action=edit Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tiny rebase.. deciding to upgrade my SO to a PQA as the patch is trivial, clear and QA scripts are happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Thank you, Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|accountline-details.pl does |Accounting transactions |not show managing librarian |dondoes not show managing |info for credits/debits |librarian info for | |credits/debits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accounting transactions |Accounting transactions |dondoes not show managing |don't show managing |librarian info for |librarian info for |credits/debits |credits/debits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accounting transactions |Accounting transactions |don't show managing |should show managing |librarian info for |librarian info for |credits/debits |credits/debits -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org