http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #0)

A possible restructuring of authorities_normal_marc21.sql that might make it easier to maintain would be to have it populate each non-default framework by first making a copy of the default tags and subfields, then removing the tags that are not relevant to the authority type.

That's easy to implement, and a great idea. Problem is (for me), which tags are not relevant? Current count of tags (with bug 9826) is +-----------------+--------------+ | count(tagfield) | authtypecode | +-----------------+--------------+ | 164 | | | 83 | CHRON_TERM | | 84 | CORPO_NAME | | 84 | GENRE/FORM | | 83 | GEOGR_NAME | | 85 | MEETI_NAME | | 84 | PERSO_NAME | | 83 | TOPIC_TERM | | 92 | UNIF_TITLE | +-----------------+--------------+ Is there some criteria over which tags are not relevant for a given auth type? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 19160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19160&action=edit Bug 10488 - New MARC21 authority tags and subfields should be propagated to non-default frameworks This is a proof of concept patch. It provides an updated (april 2013) default authority framework, then it builds all current authtypes making a copy of default without some tags/subtags, at this moment only 1XX tags and obsoleted tags (not currently present) The file is smaller and, as Galen pointed out, it's easier to mantain and guarantees that all frameworks are consistent. To test, remove all auth frameworks, then load authorities_normal_marc21.sql What is needed is an updated list of what other tags should not be copied on each auth type. I need a librarian point of view :-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19160|0 |1 is obsolete| | Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |bgkriegel@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 19253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19253&action=edit Bug 10488 - New MARC21 authority tags and subfields should be propagated to non-default frameworks As proposed by the report creator, this patch rewites authorities_normal_marc21.sql using default authority framework to build all current authtypes. Then proceed to delete not relevant tags. It also updates default authority framework to last update (April 2013) adding new or updated tags/subtags. All new tags/subtags from Bug 9826 and this one are included in all authtypes. Deleted tags reflect current situation except for 7XX tags that I was tell must be present on all authtypes. Only for new installs To test: 1) Apply patch 2) Delete all authtypes exec in database delete from auth_types; delete from auth_tag_structure; delete from auth_subfield_structure; 3) Insert new auth framework 4) Verify absent tags. This can be done running select tagfield as from auth_tag_structure where authtypecode ='' and tagfield not in (select tagfield from auth_tag_structure where authtypecode = 'AUTH_TYPE') for each authtype ( UNIF_TITLE, TOPIC_TERM, etc.) The attached PDF could be used as a reference, all that is white or green for each authtype must be in the list (except for white 7XX tags) 5) Sign :) (can't upload using git-bz) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19313&action=edit Bug 10488: Followup replacing DELETEs by more restricted INSERTs Instead of inserting followed by deleting, this patch combines the two where clauses of both sql statements, meanwhile leaving the separation intact. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: This patch makes a great contribution in removing redundancy from this file! Looks good to me. I did a fresh install and [quickly] compared the list of tags that you do not insert for the other auth types with the list on loc.gov. Note: These changes should also be propagated to the other language folders. But note that I am working on bug 10509 and its followup reports. These reports go through all folders too and will remove more redundancy. In the light of that, it may be wise to postpone this activity a little bit and communicate with each other on the progress of the other report. Thanks. BTW My followup combines your insert and delete into one more restricted insert. Just a matter of combining the two clauses. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- After applying the revised SQL, I noticed that the 162 tag (medium of performance) appears in all of the specific auth types: | CHRON_TERM | 148 | | CHRON_TERM | 162 | | CHRON_TERM | 182 | | CORPO_NAME | 110 | | CORPO_NAME | 162 | | GENRE/FORM | 155 | | GENRE/FORM | 162 | | GENRE/FORM | 185 | | GEOGR_NAME | 151 | | GEOGR_NAME | 162 | | GEOGR_NAME | 181 | | MEETI_NAME | 111 | | MEETI_NAME | 162 | | PERSO_NAME | 100 | | PERSO_NAME | 162 | | TOPIC_TERM | 150 | | TOPIC_TERM | 162 | | TOPIC_TERM | 180 | | UNIF_TITLE | 130 | | UNIF_TITLE | 162 | +--------------+----------+ The 162 certainly doesn't belong in them all, and I'm not sure if it belongs in GENRE/FORM or if a new authority type code should be defined. Setting to "In Discussion". This patch is very close to being ready, but the 162 should be dealt with, either by simply excluding it from all but the default authority type or by defining a new authority type. I'm hoping Jared can advise regarding the latter. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- In this new Bugzilla version, it happens sometimes that I cannot reply to a comment (the former comment is not pasted in to the new comment)..

The 162 certainly doesn't belong in them all, and I'm not sure if it belongs in GENRE/FORM or if a new authority type code should be defined. Good catch, Galen. Scrutiny++ :) It looks to me that this actually is a new type of authority. See for instance: http://www.loc.gov/marc/marbi/2012/2012-dp02.html

...but the 162 should be dealt with, either by simply excluding it from all but the default authority type or by defining a new authority type. I agree with Bernardo's last suggestion to exclude the 162 now. And maybe we can let Jared(..) add the new type on a separate report.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I have updated the followup for removal of 162, and park this report into Passed QA status again to the attention of Galen. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Bernardo and Marcel! -- You are receiving this mail because: You are watching all bug changes.