[Bug 30310] New: Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Bug ID: 30310 Summary: Moment.js is deprecated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org https://github.com/moment/moment Moment.js is a legacy project, now in maintenance mode. In most cases, you should choose a different library. Day.js looks like a good replacement. https://day.js.org/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 [Bug 24455] Add ability to apply Koha formatting to dates from Javascript -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135495&action=edit Bug 30310: Add dayjs v1.11.2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135496&action=edit Bug 30310: Add dayjs timezone plugin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135497&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135498&action=edit Bug 30310: Remove momentjs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135499&action=edit Bug 30310: Adjust about page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Moment.js is deprecated |Replace Moment.js with | |Day.js Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135495|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136507&action=edit Bug 30310: Add dayjs v1.11.2 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135496|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136508&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135497|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136509&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135498|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136510&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135499|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136511&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No regressions found in my testing.. passing to QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think I found a bug, it's not working if you modify dateformat. See also https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137212 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136507|0 |1 is obsolete| | Attachment #136508|0 |1 is obsolete| | Attachment #136509|0 |1 is obsolete| | Attachment #136510|0 |1 is obsolete| | Attachment #136511|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137676&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137677&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137678&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137679&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135495|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31149 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149 [Bug 31149] Use dayjs to parse dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- After applying my console has an error: Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #17)
After applying my console has an error: Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455
I tested on Tools > Calendar. In Firefox I have the same error. In Chromium I see: dayjs.min_22.0600054.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '$i') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hum, I don't recreate, but maybe was it a conflict with bug 30718? Can you try again now that 30718 has been pushed to master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135495|0 |1 is obsolete| | Attachment #137676|0 |1 is obsolete| | Attachment #137677|0 |1 is obsolete| | Attachment #137678|0 |1 is obsolete| | Attachment #137679|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 141859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141859&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 141860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141860&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 141861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141861&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 141862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141862&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #18)
(In reply to Nick Clemens from comment #17)
After applying my console has an error: Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455
I tested on Tools > Calendar. In Firefox I have the same error. In Chromium I see:
dayjs.min_22.0600054.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '$i')
I am sorry, the issue remains for me. Applied patches, restart_all. Tested in a private tab also. Firefox: Uncaught TypeError: t is undefined Chromium: dayjs.min_22.0600075.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '$i') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #24)
(In reply to Katrin Fischer from comment #18)
(In reply to Nick Clemens from comment #17)
After applying my console has an error: Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455
I tested on Tools > Calendar. In Firefox I have the same error. In Chromium I see:
dayjs.min_22.0600054.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '$i')
I am sorry, the issue remains for me. Applied patches, restart_all. Tested in a private tab also.
Firefox: Uncaught TypeError: t is undefined
Chromium: dayjs.min_22.0600075.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '$i')
How? Please provide the steps. I can go to /cgi-bin/koha/tools/holidays.pl and add new holidays, in a private window. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- https://staff-bz30310.sandboxes.biblibre.eu It's working for me there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #26)
https://staff-bz30310.sandboxes.biblibre.eu It's working for me there.
Locally I just apply patches, the error is in the console on every page - I restarted all, cleared cache, tried private window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #27)
(In reply to Jonathan Druart from comment #26)
https://staff-bz30310.sandboxes.biblibre.eu It's working for me there.
Locally I just apply patches, the error is in the console on every page - I restarted all, cleared cache, tried private window
Thx Nick, I can confirm I don't see the error on the sandbox, but saw the problem on 2 different occasions in my ktd environment. I am very sure it was reset in between too, but cannot repeat the test right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Seeing same warning about Uncaught TypeError: t is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143172&action=edit Bug 30310: Add missing utc plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #30)
Created attachment 143172 [details] [review] Bug 30310: Add missing utc plugin
Joubu> The following paths are ignored by one of your .gitignore files: Joubu> koha-tmpl/intranet-tmpl/lib/dayjs/plugin Joubu> Use -f if you really want to add them. Joubu> I have one file that is not committed there Joubu> but it does not appear in git status because "plugin" is in .gitignore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #29)
Seeing same warning about Uncaught TypeError: t is undefined
Last follow-up clears warning for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Should be good now, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143172|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143173&action=edit Bug 30310: Add missing utc plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- How are we doing here.. nearly PQA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can this be a candidate for an early push to 23.05 please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144948&action=edit Bug 30310: Replace one more occurrence to moment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144950&action=edit Bug 30310: Fix date_to_rfc3339 We need the customParseFormat plugin to provide a custom date format to the dayjs constructor. Found while working on bug 32559, don't remove this function, it will be used later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 [Bug 32559] Support formatted date for column filtering (DT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141859|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144995&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141860|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144996&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141861|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144997&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141862|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144998&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143173|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144999&action=edit Bug 30310: Add missing utc plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144948|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145000&action=edit Bug 30310: Replace one more occurrence to moment Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144950|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145001&action=edit Bug 30310: Fix date_to_rfc3339 We need the customParseFormat plugin to provide a custom date format to the dayjs constructor. Found while working on bug 32559, don't remove this function, it will be used later. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144995|0 |1 is obsolete| | Attachment #144996|0 |1 is obsolete| | Attachment #144997|0 |1 is obsolete| | Attachment #144998|0 |1 is obsolete| | Attachment #144999|0 |1 is obsolete| | Attachment #145000|0 |1 is obsolete| | Attachment #145001|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145097&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145097|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145098&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145099&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145100&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145101&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145102&action=edit Bug 30310: Add missing utc plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145103&action=edit Bug 30310: Replace one more occurrence to moment Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145104&action=edit Bug 30310: Fix date_to_rfc3339 We need the customParseFormat plugin to provide a custom date format to the dayjs constructor. Found while working on bug 32559, don't remove this function, it will be used later. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #54 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #55 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #56 from Lucas Gass <lucas@bywatersolutions.com> --- 22.05.x has the dependencies but I am not sure about backporting this at this point in the 22.05.x lifecycle. Won't backport unless convinced otherwise. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 [Bug 32505] Cannot search by dateofbirth in specified dateformat -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org