[Bug 23129] New: Items holdingbranch should be set to the originating library when generating a transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Bug ID: 23129 Summary: Items holdingbranch should be set to the originating library when generating a transfer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- In C4::Items::ModItemTransfer we call ModItem to update the holdingbranch of the item. Currently we set this to the transfer destination. By definition we are generating a transfer because the item has not yet arrived. We should set the holdingbranch to the current location of the item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90619&action=edit Bug 23129: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90620&action=edit Bug 23129: Set holdingbranch to library that initiates transfer To test: 1 - Find an item 2 - Check it in at anothe rbranch and initiate a transfer 3 - View the item details or check db - note that holdingbranch is set as the destination library 4 - Complete or cancel the transfer 5 - Apply patch 6 - Initiate a new transfer 7 - Note the holdingbranch is set to the initiating library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90619|0 |1 is obsolete| | Attachment #90620|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 91488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91488&action=edit [SIGNED-OFF] Bug 23129: Unit test Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 91489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91489&action=edit [SIGNED-OFF] Bug 23129: Set holdingbranch to library that initiates transfer To test: 1 - Find an item 2 - Check it in at anothe rbranch and initiate a transfer 3 - View the item details or check db - note that holdingbranch is set as the destination library 4 - Complete or cancel the transfer 5 - Apply patch 6 - Initiate a new transfer 7 - Note the holdingbranch is set to the initiating library Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #5 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 93043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93043&action=edit Bug 23129: Unit test Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #6 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 93045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93045&action=edit Bug 23129: Set holdingbranch to library that initiates transfer To test: 1 - Find an item 2 - Check it in at anothe rbranch and initiate a transfer 3 - View the item details or check db - note that holdingbranch is set as the destination library 4 - Complete or cancel the transfer 5 - Apply patch 6 - Initiate a new transfer 7 - Note the holdingbranch is set to the initiating library Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com Attachment #91488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works for transfers initiated by holds and on returning the item at 'not the home library'. What's missing is the same behavior manual transfers initiated from the circulation home page. I have talked to Nick and will file a new bug for that. I suggest that both should be fixed/pushed pre-release so we have the same beahviour for all kinds of transfers: Bug 23695 - Items holdingbranch should be set to the originating library when generating a manual transfer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93043|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93227&action=edit Bug 23129: Unit test Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93045|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93228&action=edit Bug 23129: Set holdingbranch to library that initiates transfer To test: 1 - Find an item 2 - Check it in at anothe rbranch and initiate a transfer 3 - View the item details or check db - note that holdingbranch is set as the destination library 4 - Complete or cancel the transfer 5 - Apply patch 6 - Initiate a new transfer 7 - Note the holdingbranch is set to the initiating library Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Apparently I forgot to switch the status... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, so this breaks a test which expects the opposite behaviour when dealing with items getting marked as lost from the transfers window. Question is, is the test incorrect or the functionality? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- CC'd Alex Buckley as he wrote the tests that's currently failing.. I'd be interested in his thoughts regarding what the holdingbranch of the item should end up as during lost in transfer processes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94219&action=edit Bug 23129: (RM follow-up) Fix failing test This patch corrects a test that was testing for the oposite behaviour to that introduced in this patchset. We have agreed on the bug that the new behaviour is desired and so I have updated the test to follow. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Discussed with Nick, the tests was wrong and so I have updated it in a followup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 15439 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #17 from Martha Fuerst <mfuerst@hmcpl.org> --- Any thoughts on backporting to 19.05? -Marti Huntsville-Madison County Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Martha Fuerst from comment #17)
Any thoughts on backporting to 19.05?
-Marti Huntsville-Madison County Public Library
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 15892 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 [Bug 25883] Show transfer on checkin screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26078 [Bug 26078] "Item returns to issuing library" creates infinite transfer loop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Martha Fuerst from comment #17)
Any thoughts on backporting to 19.05?
Hi next (i.e. current) 19.05.x maintainer here. Is there there still interest in seeing this backported? I could try to backport this and bug 26078 if you, Christopher or anyone else would be available to test that it doesn't cause regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #21 from Martha Fuerst <mfuerst@hmcpl.org> --- Yes, please. As many people won't see 19.11 until next spring and this fix greatly affects systems that do lots of transfers, I think it would be a very good idea to backport. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.16 released in| | --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27692 [Bug 27692] Unable to check-in transferred items if AllowReturnToBranch is set to 'holdingbranch' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12362 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org