https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please create a system preference for this behaviour instead of just silently removing a feature some libraries rely on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- EmailOverduesNoEmail? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Arthur Suzuki from comment #9)

Hi Katrin, Bit of followup on my side : maybe easiest to make this parameter a commandline parameter than a syspref? At least it'll be less of a hassle to maintain.

I think a cronjob parameter is more hassle than a syspref in maintaining - I need my admins to change that, a pref I can switch ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #12 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #11)

Also: think package installations with instances. If some libraries want the message and others not, I have a lot more maintenance/lines in the job. Currently it works for us with one line for everyone. Preferences mean more flexibility.

I agree wirh Katrin here. Sysprefs give more flexibility, espcially in a multi-tenant setup. It also means libraries that do not have hands on access to their Koha server can change things without relying on their provider to do it for them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Eric Swenson <tech@salinapublic.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tech@salinapublic.org --- Comment #13 from Eric Swenson <tech@salinapublic.org> --- We recently switched over to community Koha and since we are a library that is hosted by a support provider I would like to also support Katrin's suggestion for this being a system preference that I could go in an toggle. We noticed the duplicate messages as well, so it was exciting to see a bug fix already in the works. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #15 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128401&action=edit Add syspref to deal with overdues notification I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Change syspref 'EmailOverduesNoEmail' to "Don't send" 11. Delete data from message_queue (if you have access) for a cleaner view 12. Run again misc/cronjobs/overdue_notices.pl 13. Check that only the print message is now generated and not the "Overdue Notices" one. https://bugs.koha-community.org/show_bug.cgi?id=20074 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Sorry for the message at the bottom of the test plan, I miss my last attachement with git bz :/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70846|0 |1 is obsolete| | Attachment #128401|0 |1 is obsolete| | --- Comment #18 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128427&action=edit Add syspref to remove overdues notification by email to staff if user has no email address I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Run updatedabatase.pl 11. Change syspref 'EmailOverduesNoEmail' to "Don't send" 12. Delete data from message_queue (if you have access) for a cleaner view 13. Run again misc/cronjobs/overdue_notices.pl 14. Check that only the print message is now generated and not the "Overdue Notices" one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #20 from David Nind <david@davidnind.com> --- (In reply to Thibaud Guillot from comment #19)

Sorry David I miss up my attachment and some obsolete tag to apply correctly my patch (and also a important step in test plan : updatedabatase.. I'm losing my mind :') )

Now normally everything is going well

No problem! We all have those days... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #22 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- You are understanding, thank you :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128427|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 128515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128515&action=edit Add syspref to remove overdues notification by email to staff if user has no email address I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Run updatedabatase.pl 11. Change syspref 'EmailOverduesNoEmail' to "Don't send" 12. Delete data from message_queue (if you have access) for a cleaner view 13. Run again misc/cronjobs/overdue_notices.pl 14. Check that only the print message is now generated and not the "Overdue Notices" one. https://bugs.koha-community.org/show_bug.cgi?id=20076 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128713&action=edit Bug 20076: (QA follow-up) Reformat database update to use newer format -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128715&action=edit Bug 20076: (QA follow-up) We need to default to 'Send' on update to keep existing behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

Hi Katrin,

Thanks a lot for this complete review, sorry for the mistakes, but I understand now, I will keep this in mind for my future patchs.

That was my only intention, hoping to see many more patches from you! :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129458&action=edit Bug 20076: (RM follow-up) Fix default value in installer/data/mysql/mandatory/sysprefs.sql Previous patch changed default value to 1 in atomicupdate, do the same in installer/data/mysql/mandatory/sysprefs.sql Also to be consistant, sets options = NULL instead of '' in atomicupdate Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129458|0 |1 is obsolete| | --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129459&action=edit Bug 20076: (RM follow-up) Fix system preference boolean logic A Yes/No system preference must use 1 for Yes and 0 for No. So "Send" for 1/Yes and "Don't send" for 0/No. We add too much problems with double-negation boolean system preferences (such as dontmerge). Previous patch changed default value to 1 in atomicupdate, do the same in installer/data/mysql/mandatory/sysprefs.sql Also to be consistant, sets options = NULL instead of '' in atomicupdate Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This add syspref to remove release notes| |overdues notification by | |email to staff if user has | |no email address. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This add syspref to remove |Currently, two print release notes|overdues notification by |notices are generated when |email to staff if user has |running overdue_notices.pl |no email address. |if a patron does not have | |an email address: | |- a print | |overdue notice for the | |patron, and | |- an email | |message to the library with | |all the print versions of | |the overdue notices. | | | |Depending on a library's | |work processes, they may | |want both or only the | |patron print overdue notice | |generated. | | | |New system | |preference | |EmailOverduesNoEmail allows | |libraries to choose whether | |to send or not send overdue | |notices for patrons without | |an email address to library | |staff. The default is to | |send, as this preserves the | |current behaviour. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Currently, two print |Currently, two print release notes|notices are generated when |notices are generated when |running overdue_notices.pl |running overdue_notices.pl |if a patron does not have |if a patron does not have |an email address: |an email address: |- a print |- a print |overdue notice for the |overdue notice for the |patron, and |patron, and |- an email |- an email |message to the library with |message to the library with |all the print versions of |all the print versions of |the overdue notices. |the overdue notices. | | |Depending on a library's |Depending on a library's |work processes, they may |work processes, they may |want both or only the |want both or only the |patron print overdue notice |patron print overdue notice |generated. |generated. | | |New system |This |preference |enhancement adds a new |EmailOverduesNoEmail allows |system preference, |libraries to choose whether |EmailOverduesNoEmail, that |to send or not send overdue |allows libraries to choose |notices for patrons without |whether to send or not send |an email address to library |overdue notices for patrons |staff. The default is to |without an email address to |send, as this preserves the |library staff. The default |current behaviour. |is set to send, as this | |preserves the current | |behaviour. Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overdues: remove redundant |Overdues email to library |message when patrons don't |for patrons without email |have email addresses |should be optional -- You are receiving this mail because: You are watching all bug changes.