https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 --- Comment #1 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 182254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182254&action=edit Bug 39706: Add alternative text to the stars rating This patch improves the accessibility of the star ratings. To test this patch, you need to use a screen reader. Some help for using the screen reader: to navigate between links, use the Tab key, to hear the text on the page, use the arrow keys. Test Plan: 1. Enable the following system preference: OpacStarRatings (results, details, and patron). 2. Apply the patch. 3. Launch your screen reader (ex: Orca). 4. Go to the Opac interface. 5. Make a search. 6. Navigate through the record results and go to the star rating, you should hear only the rating average of each record and the number of votes. 7. On a record, do the same: go to the star rating, you should hear the rating average of the record and the number of votes. 8. Now, log into an account. 9. Make a search. 10. Navigate with the screen reader to the stars; you should hear the same information as in step 6. 11. Click on a record to view the details and navigate to the rating. Now, you can change the rating. Tab through the stars, it should tell you the number of each star. When you use the tab or arrow keys, you should still hear the average and the number of votes. 12. For this part, you need to have a record checkout (if you don't have a record checked out, go to the staff interface and do it. Choose your patron and enter the barcode of the record). 13. Go to your account. In the "Checked Out" section, navigate with the screen reader to the star rating, you should hear the number of stars and be able to change your rating or make a new one. You have to hear your rating, the average and the number of votes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182254|0 |1 is obsolete| | --- Comment #2 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 183923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183923&action=edit Bug 39706: Add alternative text to the stars rating Test Plan: 1- Enable the following system preference: OpacStarRatings (results, details, and patron). 2- Apply the patch. 3- Go to the Opac. 4- Search a record. 5- Inspect the HTML code before the stars and notice that there is "Star rating" in a span tag with the class "sr-only". Inspect the stars, there should be a span tag for each star. After the stars, notice that there is the average rating in a span with the "sr-only" class. 6- Click on a record and do the same as the 5: go to the star rating, inspect the HTML code, and notice that there is a span tag for each star. 7- Now, log into an account. 8- Search a record. 9- It should be the same information as in the step 5. 10- Click on a record to view the details. Now, you can change the rating. Inspect the stars, each should have the number of stars in the span tag with a "sr-only" class, which are in the link tags. 11- For this part, you need to have a record checked out (if you don't have a record checked out, go to the staff interface and do it. Choose your patron and enter the barcode of the record). 12- Go to your account. In the "Checked Out" section, you should see the same as in the 10 step: the number of stars and be able to change your rating or make a new one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183923|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183952&action=edit Bug 39706: Add alternative text to the stars rating Test Plan: 1- Enable the following system preference: OpacStarRatings (results, details, and patron). 2- Apply the patch. 3- Go to the Opac. 4- Search a record. 5- Inspect the HTML code before the stars and notice that there is "Star rating" in a span tag with the class "sr-only". Inspect the stars, there should be a span tag for each star. After the stars, notice that there is the average rating in a span with the "sr-only" class. 6- Click on a record and do the same as the 5: go to the star rating, inspect the HTML code, and notice that there is a span tag for each star. 7- Now, log into an account. 8- Search a record. 9- It should be the same information as in the step 5. 10- Click on a record to view the details. Now, you can change the rating. Inspect the stars, each should have the number of stars in the span tag with a "sr-only" class, which are in the link tags. 11- For this part, you need to have a record checked out (if you don't have a record checked out, go to the staff interface and do it. Choose your patron and enter the barcode of the record). 12- Go to your account. In the "Checked Out" section, you should see the same as in the 10 step: the number of stars and be able to change your rating or make a new one. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184070|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184355&action=edit Bug 39706: Add alternative text to the stars rating I just added an exception in the script. Sorry for the inconvenience. Test Plan: 1- Enable the following system preference: OpacStarRatings (results, details, and patron). 2- Apply the patch. 3- Go to the Opac. 4- Search a record. 5- Inspect the HTML code before the stars and notice that there is "Star rating" in a span tag with the class "sr-only". Inspect the stars, there should be a span tag for each star. After the stars, notice that there is the average rating in a span with the "sr-only" class. 6- Click on a record and do the same as the 5: go to the star rating, inspect the HTML code, and notice that there is a span tag for each star. 7- Now, log into an account. 8- Search a record. 9- It should be the same information as in the step 5. 10- Click on a record to view the details. Now, you can change the rating. Inspect the stars, each should have the number of stars in the span tag with a "sr-only" class, which are in the link tags. 11- For this part, you need to have a record checked out (if you don't have a record checked out, go to the staff interface and do it. Choose your patron and enter the barcode of the record). 12- Go to your account. In the "Checked Out" section, you should see the same as in the 10 step: the number of stars and be able to change your rating or make a new one. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184355|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 187096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187096&action=edit Bug 39706: Add alternative text to the stars rating I just added an exception in the script. Sorry for the inconvenience. Test Plan: 1- Enable the following system preference: OpacStarRatings (results, details, and patron). 2- Apply the patch. 3- Go to the Opac. 4- Search a record. 5- Inspect the HTML code before the stars and notice that there is "Star rating" in a span tag with the class "sr-only". Inspect the stars, there should be a span tag for each star. After the stars, notice that there is the average rating in a span with the "sr-only" class. 6- Click on a record and do the same as the 5: go to the star rating, inspect the HTML code, and notice that there is a span tag for each star. 7- Now, log into an account. 8- Search a record. 9- It should be the same information as in the step 5. 10- Click on a record to view the details. Now, you can change the rating. Inspect the stars, each should have the number of stars in the span tag with a "sr-only" class, which are in the link tags. 11- For this part, you need to have a record checked out (if you don't have a record checked out, go to the staff interface and do it. Choose your patron and enter the barcode of the record). 12- Go to your account. In the "Checked Out" section, you should see the same as in the 10 step: the number of stars and be able to change your rating or make a new one. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 [Bug 41128] ratings.js creating "undefined" text for screen readers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- I'm not sure what the purpose of the following: "Inspect the HTML code before the stars and notice that there is "Star rating" in a span tag with the class "sr-only". Inspect the stars, there should be a span tag for each star." Although it looks like that output has been there for many years... no idea why. It's just the Javascript from this bug which accidentally breaks the output I think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x (hard to backport since tidy) -- You are receiving this mail because: You are watching all bug changes.