[Bug 8583] New: Add a warning if a Z39.50 search is started from the "Edit biblio record" page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Priority: P5 - low Change sponsored?: --- Bug ID: 8583 CC: m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Add a warning if a Z39.50 search is started from the "Edit biblio record" page Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla@live.ca Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Created attachment 11392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11392&action=edit Add a warning if a Z39.50 search is started from biblio edition page. If the "Z39.50 Search" is clicked when editing an existing biblio record, the current record will be overwritten by the imported Z39.50 record. This patch simply adds a warning when the button is clicked so the user is aware that doing a Z39.50 import from the edition page will overwrite the current record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |fcapovilla@live.ca --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Owen had a good suggestion. Rather than adding an additional click every time someone clicks the "Z39.50 Search" button, perhaps we could change the label to something like "Replace with Z39.50"? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11392|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 12026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12026&action=edit [SIGNED-OFF] Add a warning if a Z39.50 search is started from biblio edition page. Warn the user that the current biblio record might be overwritten by this action. http://bugs.koha-community.org/show_bug.cgi?id=8583 Signed-off-by: Marc Veron <veron@veron.ch> Woks as expected. I prefer this solution with an explicit warning, since several times I acidentally changed a record :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * tiny patch, no side effect risk * passes koha-qa.pl passed QA Question: why does the message say: "could replace" ? It "will" replace isn't it ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|enhancement |minor --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master. More a minor bugfix than an ENH, but chris, up to you, as usual -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure I like this change - actually I think it's a bit annoying for an experienced cataloger. Wouldn't it be better to change the button labelling maybe? It could say "Z39.50 overlay" or something else that makes sense in English. Also, the prompt always appears, even for a totally empty that has not been saved yet. It's totally unnecessary in this case. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9742 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have filed a separate bug - maybe we can just make it appear a bit less often by eliminiating the prompt for a new record (bug 9742)? I understand the idea behind this - I was only taken a bit by surprise today when testing something else. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org