[Bug 18348] New: SHOW_BCODE should be a column of the borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 Bug ID: 18348 Summary: SHOW_BCODE should be a column of the borrowers table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The SHOW_BCODE is a hidden feature, not translatable and does not exist for all languages. It sounds like it should be a column of the borrowers table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4157 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4157 [Bug 4157] Display of barcode in checked out items in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11922 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Or maybe it should be deprecated in favor of settings on the category type or a column configuration setting? Not sure hwo granular display stuff like this needs to be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Katrin Fischer from comment #1)
Or maybe it should be deprecated in favor of settings on the category type or a column configuration setting? Not sure hwo granular display stuff like this needs to be.
I was leaning in the direction of something in the column settings, but right now, it seems to be set on a individual basis. If we transfer it somewhere, it probably should be somewhere in the patron categories, so as not to change the feature too much for libraries already using it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would be really interesting to get feedback on this from libraries using it. I think it was introduced with the extended patron attributes, maybe as some kind of example? But I never quite understood the use case. Maybe we could even do without? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really feel like it is overkill as a per person setting. I wonder who is using it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It only seems to affect the items table in the OPAC? Maybe. opac/opac-user.pl: use constant ATTRIBUTE_SHOW_BARCODE => 'SHOW_BCODE'; my $show_barcode = Koha::Patron::Attribute::Types->search( # FIXME we should not need this search { code => ATTRIBUTE_SHOW_BARCODE } )->count; if ($show_barcode) { my $patron_show_barcode = $patron->get_extended_attribute(ATTRIBUTE_SHOW_BARCODE); undef $show_barcode if $patron_show_barcode and not $patron_show_barcode->attribute; } $template->param( show_barcode => 1 ) if $show_barcode; -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org