[Bug 23898] New: New data to share on HEA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Bug ID: 23898 Summary: New data to share on HEA Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: paul.poulain@biblibre.com QA Contact: testopia@bugs.koha-community.org Some ideas of thing that could be shared on HEA for statistics purposes: - adding some statistics like "intranetuserjs yes/no" => yes if there's something, no if it's empty ? (intranetuserjs, opacuserjs, opac & intranet css, opacheader, opacnav, opacbottom). - For sysprefs *XSLT* => we could send "empty/default/local". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 23897 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23849 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23914 CC| |victor@tuxayo.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Similar sysprefs to consider also. Maybe in a followup bug. AmazonAssocTag IntranetCirculationHomeHTML IntranetFavicon IntranetmainUserblock IntranetNav IntranetReportsHomeHTML IntranetSlipPrinterJS intranetstylesheet OpacCustomSearch OPACHoldsIfAvailableAtPickupExceptions OpacLoginInstructions OpacMainUserBlock OpacMoreSearches OPACResultsSidebar OPACSearchForTitleIn ProcessingFeeNote RestrictedPageContent RoutingListNote SpineLabelFormat XSLTDetailsDisplay -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #2)
Similar sysprefs to consider also. Maybe in a followup bug.
AmazonAssocTag IntranetCirculationHomeHTML IntranetFavicon IntranetmainUserblock IntranetNav IntranetReportsHomeHTML IntranetSlipPrinterJS intranetstylesheet OpacCustomSearch OPACHoldsIfAvailableAtPickupExceptions OpacLoginInstructions OpacMainUserBlock OpacMoreSearches OPACResultsSidebar OPACSearchForTitleIn ProcessingFeeNote RestrictedPageContent RoutingListNote SpineLabelFormat XSLTDetailsDisplay
I don't think we will gain much from sharing these if anything at all and they are all likely to include very library specific information. I think we should not share them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Empty or 'used' might work, but not sure about the information gain and it might scare people of thinking we share the actual content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Victor, we don't want more sysprefs. The goal was to double-check, from the whitelist I provided, if they were all valid and relevant: we don't want personal data to be shared. A second pass could be done for the new prefs we added since I worked on this. Don't rethink/redo the whole process please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #4)
Empty or 'used' might work, but not sure about the information gain and it might scare people of thinking we share the actual content.
+1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23911 CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 176577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176577&action=edit Bug 23898: Share more data to HEA : test plan It would be nice to get more data about which functionnality are used or not. This could be achieved with sharing some systempreferences. However some of the systempreferences may hold some private information. This patch propose a way to share some syspref usage without sharing their values. Test plan : - apply test patch - prove t/db_dependent/UsageStats.t -> fail - apply code patch - prove t/db_dependent/UsageStats.t -> green Once this patch is applied to a production environment with HEA enabled, more systempreferences will be shared but those which values are meant to be private will only send "Empty" or "Used" value instead of the actual value. This will help the community find out about unused or rarely used functionnality and debug some specific systempreference combinations which may cause an issue. (this commit holds the tests) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 176578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176578&action=edit Bug 23898: Share new data to HEA Test plan : Apply test patch prove t/db_dependent/UsageStats.t -> fail apply patch prove t/db_dependent/UsageStats.t -> green After patch is applied to a production environment with HEA sharing enabled, more data will be shared to the community. Those data will help us clean some unused functionnality or debug some rare case where systempreferences configuration might be broken. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- OpacMainUserBlock is not a system preference anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176577|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190658&action=edit Bug 23898: Share more data to HEA : test plan It would be nice to get more data about which functionnality are used or not. This could be achieved with sharing some systempreferences. However some of the systempreferences may hold some private information. This patch propose a way to share some syspref usage without sharing their values. Test plan : - apply test patch - prove t/db_dependent/UsageStats.t -> fail - apply code patch - prove t/db_dependent/UsageStats.t -> green Once this patch is applied to a production environment with HEA enabled, more systempreferences will be shared but those which values are meant to be private will only send "Empty" or "Used" value instead of the actual value. This will help the community find out about unused or rarely used functionnality and debug some specific systempreference combinations which may cause an issue. (this commit holds the tests) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176578|0 |1 is obsolete| | --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190659&action=edit Bug 23898: Share new data to HEA Test plan : Apply test patch prove t/db_dependent/UsageStats.t -> fail apply patch prove t/db_dependent/UsageStats.t -> green After patch is applied to a production environment with HEA sharing enabled, more data will be shared to the community. Those data will help us clean some unused functionnality or debug some rare case where systempreferences configuration might be broken. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- By messing with the tests, I confirmed that '' (empty string), 0 , 0.0 are considered empty. QA note: the test case for empty with IntranetUserCSS relies on it being empty the base test data. I though it relied on IntranetUserCSS not existing at all in the DB (which wouldn't match how sysprefs work) but no it's ok, it's realistic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New data to share on HEA |New data to share on Hea -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx for testing that Victor, it's been a long time! (merry xmas!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 🎉 ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- These sysprefs don't exist anymore: Bug 35153: IntranetmainUserblock Bug 34561: IntranetReportsHomeHTML bug 23796: OpacCustomSearch bug 23797: OpacLoginInstructions Bug 23794: OpacMainUserBlock Bug 24220: OpacMoreSearches Bug 34869: OPACResultsSidebar Bug 35152: RoutingListNote -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190658|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190659|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 196102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196102&action=edit Bug 23898: Share more data to HEA : test plan It would be nice to get more data about which functionnality are used or not. This could be achieved with sharing some systempreferences. However some of the systempreferences may hold some private information. This patch propose a way to share some syspref usage without sharing their values. Test plan : - apply test patch - prove t/db_dependent/UsageStats.t -> fail - apply code patch - prove t/db_dependent/UsageStats.t -> green Once this patch is applied to a production environment with HEA enabled, more systempreferences will be shared but those which values are meant to be private will only send "Empty" or "Used" value instead of the actual value. This will help the community find out about unused or rarely used functionnality and debug some specific systempreference combinations which may cause an issue. (this commit holds the tests) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 196103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196103&action=edit Bug 23898: Share new data to HEA Test plan : Apply test patch prove t/db_dependent/UsageStats.t -> fail apply patch prove t/db_dependent/UsageStats.t -> green After patch is applied to a production environment with HEA sharing enabled, more data will be shared to the community. Those data will help us clean some unused functionnality or debug some rare case where systempreferences configuration might be broken. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org