[Bug 25499] New: Fund code column is empty when closing a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Bug ID: 25499 Summary: Fund code column is empty when closing a budget Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When closing a budget, the fund code is missing from the table showing the number of unreceived orders for each fund. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- To test: - Create a budget and fund - Order anything, leave basket open or not, but don't receive - Duplicate your existing budget - Close the first budget in order to move the pending orders - Verify the fund code is not showing in the table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This change makes the code appear, but it might need more work ad I think the intention probably was to show indentation for child funds: - <td>[% budget.budget_code_indent | html %]</td> + <td>[% budget.budget_code | html %]</td> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11714 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems that budget_code_indent has been added to this template by commit a12e96e938c9203e5fb98d7ab74e77d0b22f34ba Bug 12164: Move the budget period clone logic into C4::Budgets Pushed on Jul 24 2014 but dropped by commit 32bd54a7cadcf90be797afa1a8e9f1bf83c6ee57 Bug 11714 - GetBudgetHierarchy needs optimization Pushed on Oct 31 2014 They certainly overlapped during the SO+QA process I think your patch is correct. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 [Bug 11714] GetBudgetHierarchy needs optimization -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105294&action=edit Bug 25499: Fix fund code column when closing a budget When closing a budget the fund code column in the table is always empty. This is due to a TT variable not being correct. To test: - Create a budget and fund - Order anything, leave basket open or not, but don't receive - Duplicate your existing budget - Close the first budget in order to move the pending orders - Verify the fund code is not showing in the table - Apply patch and reload the patch - Verify fund codes are now showing correctly Bonus: Changes the column heading Fund id to Fund ID. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for reviewing and digging, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105294|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106636&action=edit Bug 25499: Fix fund code column when closing a budget When closing a budget the fund code column in the table is always empty. This is due to a TT variable not being correct. To test: - Create a budget and fund - Order anything, leave basket open or not, but don't receive - Duplicate your existing budget - Close the first budget in order to move the pending orders - Verify the fund code is not showing in the table - Apply patch and reload the patch - Verify fund codes are now showing correctly Bonus: Changes the column heading Fund id to Fund ID. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot, Abbey! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us Status|Needs Signoff |Signed Off --- Comment #8 from Abbey Holt <aholt@dubuque.lib.ia.us> --- It worked great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106636|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 107494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107494&action=edit Bug 25499: Fix fund code column when closing a budget When closing a budget the fund code column in the table is always empty. This is due to a TT variable not being correct. To test: - Create a budget and fund - Order anything, leave basket open or not, but don't receive - Duplicate your existing budget - Close the first budget in order to move the pending orders - Verify the fund code is not showing in the table - Apply patch and reload the patch - Verify fund codes are now showing correctly Bonus: Changes the column heading Fund id to Fund ID. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in| |19.11.09 CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org