[Bug 10535] New: by default sort funds by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Bug ID: 10535 Summary: by default sort funds by name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com In parcels.pl, and other acquisition pages, the funds are not sorted by name in combo-box. With a great number of founds, it is difficult to find one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19365&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Silvia Simonetti <s.simonetti@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19402&action=edit [SIGNED-OFF] Bug 10535 - by default sort funds by name Something went wrong with sandbox, I created signed patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19402|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19539&action=edit [PASSED QA] Bug 10535 - by default sort funds by name In parcels.pl, and other acquisition pages, the funds are not sorted by name in combo-box. With a great number of funds, it is difficult to find one. This patch adds a default value to $orderby arg of C4::Budgets::GetBudgets. Test plan : - Create a new fund with a name beginning with 'z' and set you as owner. - Create a new fund with a name beginning with 'a' and set you as owner. - Go to a vendor and click "Receive shipments" - Look at fund combobox => Funds are sorted by name Signed-off-by: Silvia Simonetti <s.simonetti@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. When testing make sure your funds would sort the other way around when sorting by code instead of description. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Fridoyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19539|0 |1 is obsolete| | --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 19579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19579&action=edit Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10577 --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- I've attached a follow-up patch that adds a test case for the change to the default sort order. I very much prefer that *all* changes to routines in C4 and Koha be accompanied by test cases. Note that in order for this patch to apply cleanly, the patch for bug 10577 must be applied first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The first patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Galen Charlton from comment #7)
I've attached a follow-up patch that adds a test case for the change to the default sort order. I very much prefer that *all* changes to routines in C4 and Koha be accompanied by test cases.
Note that in order for this patch to apply cleanly, the patch for bug 10577 must be applied first.
I applied 10577, then 10535, ran the test, and all looked good. Since 10577 has failed QA, what's the proper process now? Wait until 10577 passes QA or is pushed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- First patch pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #11 from Chris Hall <chrish@catalyst.net.nz> --- First patch pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19579|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 20563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20563&action=edit Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20563|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20579&action=edit Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to 3.12.x, will be in 3.12.8. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org