[Bug 26594] New: Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Bug ID: 26594 Summary: Patrons merge problem with restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 [Bug 9302] Add ability to merge patron records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111036&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I'm working on a unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111058&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111036|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111059&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- We should work on using Koha objects for debarments. And remove debarred from borrowers table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111058|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 111197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111197&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111059|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 111198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111198&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111198|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111702&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111197|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111703&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111702|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111704&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Signed Off --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not convince by this patch, we should not call a private method. Asking for a second QA POV. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111703|0 |1 is obsolete| | Attachment #111704|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112849&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112850&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #11)
I am not convince by this patch, we should not call a private method. Asking for a second QA POV.
Kyle, can you confirm that you see this comment before you PQAed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113094&action=edit Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- this didn't work for me on 19.11.x, the tests passed cleanly but i still so no restrictions on patron B after merging patron A into patron B. not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org