[Bug 16103] New: FK in deletedborrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Bug ID: 16103 Summary: FK in deletedborrowers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 49312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49312&action=edit Bug 16103: Remove FK sms_provider_id in deletedborrowers This patch removes the FK constraint for sms_provider_id in table deletedborrowers. (We do not need FKs in that table.) It just corrects a newly added db revision in updatedatabase. If this is pushed before releasing master, no need to do anything more. Note that this key was not found in kohastructure and the DBIx schema. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|FK in deletedborrowers |Remove FK sms_provider_id | |in deletedborrowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove FK sms_provider_id |Remove FK constraint for |in deletedborrowers |sms_provider_id in | |deletedborrowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED CC| |brendan@bywatersolutions.co | |m --- Comment #2 from Brendan Gallagher <brendan@bywatersolutions.com> --- Fixed in Master! (just pushed update) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49312|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49742&action=edit Bug 16103: Remove FK sms_provider_id in deletedborrowers This patch removes the FK constraint for sms_provider_id in table deletedborrowers. (We do not need FKs in that table.) It just corrects a newly added db revision in updatedatabase. If this is pushed before releasing master, no need to do anything more. Note that this key was not found in kohastructure and the DBIx schema. Edit: To test: - With master DB run $ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests pass - Create a clean 3.22.00 DB - Run the upgrade process $ perl installer/data/mysql/updatedatabase.pl - Run $ prove t/db_dependent/TestBuilder.t => FAIL: Tests fail due to discrepancies in DB structure - Re-create teh clean 3.22.00 DB - Apply the patch - Run the upgrade process $ perl installer/data/mysql/updatedatabase.pl - Run $ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests now pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org