[Bug 22949] New: Markup error in OPAC course reserves template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Bug ID: 22949 Summary: Markup error in OPAC course reserves template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- There is a missing "=" in opac-course-reserves.tt which causes validation errors: - 'Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.' - 'Attribute class"inst_surname" not allowed on element span at this point.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89944&action=edit Bug 22949: Markup error in OPAC course reserves template This patch adds a missing "=" in opac-course-reserves.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have one or more course reserves available in the OPAC. Go to the course reserves page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses these errors: - 'Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.' - 'Attribute class"inst_surname" not allowed on element span at this point.' To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 frederik.chenier@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89944|0 |1 is obsolete| | --- Comment #2 from frederik.chenier@inlibro.com --- Created attachment 90934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90934&action=edit Bug 22949: Markup error in OPAC course reserves template This patch adds a missing "=" in opac-course-reserves.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have one or more course reserves available in the OPAC. Go to the course reserves page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses these errors: - 'Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.' - 'Attribute class"inst_surname" not allowed on element span at this point.' To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: frederik <frederik@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Signed Off --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Frederik forgot to mark as signed off. Eyeballs well from my perspective. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90934|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90978&action=edit Bug 22949: Markup error in OPAC course reserves template This patch adds a missing "=" in opac-course-reserves.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have one or more course reserves available in the OPAC. Go to the course reserves page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses these errors: - 'Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.' - 'Attribute class"inst_surname" not allowed on element span at this point.' To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org