[Bug 35006] New: OPAC holdings table - sort for current library column doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Bug ID: 35006 Summary: OPAC holdings table - sort for current library column doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org In the OPAC, the sort by 'Current library' in the holdings table for a record doesn't work. Sorting of other columns seem to work okay (change one of the item types for an item, collection code, and add different call numbers to test). To replicate: 1. Go to a record in the OPAC that has multiple items in different libraries (126 - Intermediate Perl has four items in three different libraries). 2. In the holdings tab, click the 'Current library' column. 3. Note that the sort order doesn't change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed the bug, but not sure what the problem is :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | Depends on| |31313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 [Bug 31313] Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156797&action=edit Bug 35006: OPAC holdings table - Fix sort for library columns This patch updates the holdings table on the OPAC's bibliographic detail page so that home and current library columns can be sorted correctly by library name. There have been changes to the way the template shows these values, but the DataTables "data-sort" attribute on the table cell had not been updated accordingly. To test, apply the patch set the OpacLocationBranchToDisplay system preference to "home and holding libraries." - Make sure home and holding library columns are not hidden in the table settings under Administration -> Table settings -> OPAC -> holdingst. - Locate a bibliographic record in the OPAC which has multiple items from different libraries. - Test that the home and current library columns sort correctly by library name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156797|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 156804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156804&action=edit Bug 35006: OPAC holdings table - Fix sort for library columns This patch updates the holdings table on the OPAC's bibliographic detail page so that home and current library columns can be sorted correctly by library name. There have been changes to the way the template shows these values, but the DataTables "data-sort" attribute on the table cell had not been updated accordingly. To test, apply the patch set the OpacLocationBranchToDisplay system preference to "home and holding libraries." - Make sure home and holding library columns are not hidden in the table settings under Administration -> Table settings -> OPAC -> holdingst. - Locate a bibliographic record in the OPAC which has multiple items from different libraries. - Test that the home and current library columns sort correctly by library name. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156804|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156873&action=edit Bug 35006: OPAC holdings table - Fix sort for library columns This patch updates the holdings table on the OPAC's bibliographic detail page so that home and current library columns can be sorted correctly by library name. There have been changes to the way the template shows these values, but the DataTables "data-sort" attribute on the table cell had not been updated accordingly. To test, apply the patch set the OpacLocationBranchToDisplay system preference to "home and holding libraries." - Make sure home and holding library columns are not hidden in the table settings under Administration -> Table settings -> OPAC -> holdingst. - Locate a bibliographic record in the OPAC which has multiple items from different libraries. - Test that the home and current library columns sort correctly by library name. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the holdings release notes| |table on the OPAC's | |bibliographic detail | |page | |so that home and current | |library columns are sorted | |correctly by | |library name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35319 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org