[Bug 22399] New: Improve responsive behavior of the basic marc editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug ID: 22399 Summary: Improve responsive behavior of the basic marc editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl, testopia@bugs.koha-community.org Depends on: 22045 Target Milestone: --- Created attachment 85569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85569&action=edit Animated gif showing the proposed style update I propose to make some markup and style changes to the MARC editor to improve its handling of smaller browser widths. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 [Bug 22045] Cataloging UX enhancement - Improve access to tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85570&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds Bootstrap grid markup to the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. Adjust your browser width and confirm that the form adjusts well to various widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85570|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85572&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds Bootstrap grid markup to the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. Adjust your browser width and confirm that the form adjusts well to various widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85572|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85621&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds Bootstrap grid markup to the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. Adjust your browser width and confirm that the form adjusts well to various widths. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85621|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85666&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds Bootstrap grid markup to the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. Adjust your browser width and confirm that the form adjusts well to various widths. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Highlight required field in MARC editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #7 from Dobrica Pavlinusic <dpavlin@rot13.org> --- It seems that this patch broke javascript functionality to move subfileds up (implemented in upSubfield inside js/cataloging.js). Seems that <div id="row"> is special to this code, and this patch changes how it's used in semantic markup, this breaking editor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 [Bug 22582] Authority plugin link broken by Bug 22399 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- This had unintended consequences that broke other features. Reverted from master a993bd3843fdfcf3a7f2df916299b32d4601b879 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 22582 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Delete from 19.05 release release notes| |notes, has been reverted! CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 [Bug 22768] Basic MARC editor tab keyboard navigation broekn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Delete from 19.05 release |RMNOTE Delete from 19.05 release notes|notes, has been reverted! |release notes, has been | |reverted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Required fields in the MARC editor should be highlighted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7890 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- One to bring back to life for this new cycle Owen? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Required fields in the MARC editor should be highlighted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 [Bug 23159] Reindent addbiblio.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Required fields in the MARC editor should be highlighted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 [Bug 23183] Reindent cataloging.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 23159, which changed state. Bug 23159 Summary: Reindent addbiblio.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 23159, which changed state. Bug 23159 Summary: Reindent addbiblio.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 22768, which changed state. Bug 22768 Summary: Global search forms' keyboard navigation broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106877&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds flexbox styling to elements of the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. - Adjust your browser width and confirm that the form adjusts well to various widths. - Test that the markup changes haven't broken the JavaScript-driven features in the editor: - Clone tags - Delete tags - Expand and collapse tags - Clone subfields - Delete subfields - Re-order subfields - Cataloging plugins: - Focus-driven plugins like on tag 000 - Popup plugins like 008 or authority-linked tags - Select2-styled dropdowns (e.g. 942$c Item type). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106878&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds flexbox styling to elements of the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. - Adjust your browser width and confirm that the form adjusts well to various widths. - Test that the markup changes haven't broken the JavaScript-driven features in the editor: - Clone tags - Delete tags - Expand and collapse tags - Clone subfields - Delete subfields - Re-order subfields - Cataloging plugins: - Focus-driven plugins like on tag 000 - Popup plugins like 008 or authority-linked tags - Select2-styled dropdowns (e.g. 942$c Item type). - Test the add/edit items form to confirm that it is still styled as it was before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22582 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 [Bug 22582] Authority plugin link broken by Bug 22399 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106878|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109855&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds flexbox styling to elements of the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. - Adjust your browser width and confirm that the form adjusts well to various widths. - Test that the markup changes haven't broken the JavaScript-driven features in the editor: - Clone tags - Delete tags - Expand and collapse tags - Clone subfields - Delete subfields - Re-order subfields - Cataloging plugins: - Focus-driven plugins like on tag 000 - Popup plugins like 008 or authority-linked tags - Select2-styled dropdowns (e.g. 942$c Item type). - Test the add/edit items form to confirm that it is still styled as it was before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #14 from David Nind <david@davidnind.com> --- Hi Owen. Although I'm not a cataloguer, I like the enhancement. Particularly the subfield names being to the left of the input field, rather than above - seemed easier to scan and read to me. Some things I noted: - The authority lookup pop up window: when I click on this, then search, then select something there is another pop up window - this just "spins" saying "Loading", so seems to have been broken (example in KTD: biblionumber 16 (Four metaphysical poets), 650a > Select authority control, click search in the pop up window, choose a term). - Related to above: can get an error trace message if you choose a result that has no value (example in KTD: biblionumber 16 (Four metaphysical poets), 100$a
Select authority control, click search in the pop up window, choose the first term (which is Personal names: [without a value])
Can't call method "subfields" on an undefined value at /kohadevbox/koha/authorities/blinddetail-biblio-search.pl line 89 in (eval) at /kohadevbox/koha/authorities/blinddetail-biblio-search.pl line 89 86: 87: # Get all values for each distinct subfield and add to subfield loop 88: my %done_subfields; 89: for ( $field->subfields ) { 90: next if $_->[0] eq '9'; # $9 will be set with authid value 91: my $letter = $_->[0]; 92: $letter ||= '@'; - Does this change affect the authority editor as well? When you first load, say for the 0 tab it display like it used to - clicking on the MARC field name displays the updated way, required fields are at the start rather than the end as for the MARC editor. Field names are aligned at the bottom of the input field rather than the top when screen size is narrow. Clone and elete buttons are vitical rather than horizontal as in the MARC editor. (Not sure if this makes sense, can add some screenshots if it will help). As I'm not a cataloguer, it would be nice to get some input from someone who uses it all the time as I've probably missed something. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #15 from David Nind <david@davidnind.com> --- A couple of other things I noticed: - Drop down list, such as 942$2 and 942$c: when screen is narrow, the drop down list is very wide and is not aligned to the right with other fields - Fields highlighted with a gray background: in Firefox there is no right hand side and bottom dark border. All the borders are darker when you are click in the field. In chromium/Google chrome when you click in the fields the border is thicker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109855|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112045&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds flexbox styling to elements of the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. - Adjust your browser width and confirm that the form adjusts well to various widths. - Test that the markup changes haven't broken the JavaScript-driven features in the editor: - Clone tags - Delete tags - Expand and collapse tags - Clone subfields - Delete subfields - Re-order subfields - Cataloging plugins: - Focus-driven plugins like on tag 000 - Popup plugins like 008 or authority-linked tags - Select2-styled dropdowns (e.g. 942$c Item type). - Test the add/edit items form to confirm that it is still styled as it was before. Edit: The Select2 plugin JavaScript file now accepts a variable to set the "width" configuration option. It still defaults to "element." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #14)
- The authority lookup pop up window: when I click on this, then search, then select something there is another pop up window - this just "spins"
This should be fixed now.
- Related to above: can get an error trace message if you choose a result that has no value
I believe this is also fixed.
- Does this change affect the authority editor as well?
It doesn't. (In reply to David Nind from comment #15)
- Drop down list, such as 942$2 and 942$c: when screen is narrow, the drop down list is very wide and is not aligned to the right with other fields
This should be fixed.
- Fields highlighted with a gray background: in Firefox there is no right hand side and bottom dark border.
I don't think this style has changed at all. I think it's the same as before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112045|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 112390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112390&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds flexbox styling to elements of the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. - Adjust your browser width and confirm that the form adjusts well to various widths. - Test that the markup changes haven't broken the JavaScript-driven features in the editor: - Clone tags - Delete tags - Expand and collapse tags - Clone subfields - Delete subfields - Re-order subfields - Cataloging plugins: - Focus-driven plugins like on tag 000 - Popup plugins like 008 or authority-linked tags - Select2-styled dropdowns (e.g. 942$c Item type). - Test the add/edit items form to confirm that it is still styled as it was before. Edit: The Select2 plugin JavaScript file now accepts a variable to set the "width" configuration option. It still defaults to "element." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #19 from David Nind <david@davidnind.com> --- Thanks Owen for the updated patch! Just confirming that the field highlighting behaviour in Firefox is the same before and after the patch is applied. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112390|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112446&action=edit Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds flexbox styling to elements of the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. - Adjust your browser width and confirm that the form adjusts well to various widths. - Test that the markup changes haven't broken the JavaScript-driven features in the editor: - Clone tags - Delete tags - Expand and collapse tags - Clone subfields - Delete subfields - Re-order subfields - Cataloging plugins: - Focus-driven plugins like on tag 000 - Popup plugins like 008 or authority-linked tags - Select2-styled dropdowns (e.g. 942$c Item type). - Test the add/edit items form to confirm that it is still styled as it was before. Edit: The Select2 plugin JavaScript file now accepts a variable to set the "width" configuration option. It still defaults to "element." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a JS error if a select2.js is used outside of addbiblio.tt: ReferenceError: select2Width is not defined Edit items view for instance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 [Bug 27124] JS error "select2Width is not defined" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #23)
There is a JS error if a select2.js is used outside of addbiblio.tt: ReferenceError: select2Width is not defined
Edit items view for instance.
See bug 27124. Owen can you deal with it please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 [Bug 27737] Tag editor for authority lookup broken in authority editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27838 [Bug 27838] See also authorities not copied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 [Bug 28828] (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28738 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org