[Bug 5593] New: Change cart markup to allow for easier icon styling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 Summary: Change cart markup to allow for easier icon styling Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 If we replace the inline image in the cart to a span with an ID it should make it easier for libraries to change the icon. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-01-07 16:57:59 UTC --- Shouldn't we do the same for Lists? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-01-07 17:05:31 UTC ---
Shouldn't we do the same for Lists?
This patch arises as a result of my work trying to get Bug 3719 working ("Create syspref to allow sites to rename OPAC Cart") so it seeks to address that specific case. Do you hear requests to similarly change the style of the Lists button? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-01-07 17:09:28 UTC --- I have not as of yet, but that said, if you're touching that code it seems like it would make sense to just make both buttons customizable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-01-07 17:26:10 UTC --- Created attachment 2966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2966 Proposed change Replacing inline cart image with a span with a unique ID. Adding styling to the deafult CSS to give that span a background of the same cart image as before. Custom CSS can override this with a different image. Example for OPACUserCSS preference: #cartmenulink span#carticon { background-image : url("/opac-tmpl/prog/famfamfam/silk/basket.png"); width:16px; height:16px; } -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 --- Comment #5 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-02-04 09:13:33 UTC --- This bug is mentioned in: Fix for Bug 5593, Change cart markup to allow for easier icon styling http://lists.koha-community.org/pipermail/koha-patches/2011-January/013553.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-18 22:41:48 UTC --- Created attachment 3355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3355 signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-05 03:05:25 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5593 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org