[Bug 5143] New: Subtitles not showing on view_holdsqueue.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Summary: Subtitles not showing on view_holdsqueue.pl Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: wizzyrea@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 see: http://screencast.com/t/OWE5NzMxZWMt Subtitles are not showing on the Holds Queue list, making it very time consuming for librarians to pick items that are in a series. The holds queue used to show the barcode of the item to be picked, making it eas(ier) for the librarian to find the right item to fill a hold. Without the subtitles AND without the barcode, they have to click through to each subtitled item to figure out which item to pull. I propose adding the subtitles into the holds queue list, and considering adding the specific item barcode back in as well (though there may be a reason not to do that). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2010-08-17 21:20:05 UTC --- The specific barcode is there, if a specific item was requested. Any available title does let the person know, any copy on the shelf will suffice. But adding in the subtitle, $b and $p and $n at least for libraries using MARC21 is certainly doable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2010-08-17 21:27:13 UTC --- Using the Keyword to MARC mappings /cgi-bin/koha/admin/fieldmapping.pl We can define mappings for those subfields, then we can use those mappings to make a multi marc compliant solution. Using GetRecordValue from C4::Biblio -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2010-08-17 21:57:38 UTC --- Created attachment 2533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2533 Potential fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2010-08-18 00:00:16 UTC ---
Any available title does let the person know, any copy on the shelf will suffice.
The trouble with this is when your library has more than one copy of the same title, but because they have different ISBNs they were cataloged under separate records. Pulling one of the two [different] copies of that title has only a 50% chance of fulfilling the hold in your report. We use a custom PHP script which pulls from Koha's holdsqueue table and does a "limit 1" query for barcode for each item in the holds list. It has worked well for us. I don't know whether a similar method would work well as a built-in report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com --- Comment #5 from Jane Wagner <jwagner@ptfs.com> 2010-08-18 11:23:23 UTC --- I see there was a followup patch; is the version attached to this bug report the correct one? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2010-08-18 12:24:26 UTC --- I'm assuming the modifications to addbiblio.tmpl in this patch are unrelated? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #7 from Liz Rea <wizzyrea@gmail.com> 2010-08-18 14:34:46 UTC --- I can confirm that with chris's patch, subtitles are now showing in the View Holdsqueue. There is still the matter of the barcodes that owen brings up, but this patch definitely helps the bigger issue with our libraries, which is picking items with entries in the 245 $p, $n, $b, and $h. http://screencast.com/t/ZGZjMTdjND -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2010-08-18 14:45:39 UTC --- For purposes of comparison: this is the holds queue list that we are currently using. It was customized by me to only show what we wanted. http://screencast.com/t/ZmE5NDcyY Additionally, putting patron information on the holds queue, while helpful, requires librarians to shred the list when they are done. We omitted it for that reason, as the information is printed on the slip when the item is checked in. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> 2010-08-18 19:59:56 UTC --- Created attachment 2551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2551 followup-putting the subtitles in the URL for title -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #10 from Liz Rea <wizzyrea@gmail.com> 2010-08-18 21:32:32 UTC --- Created attachment 2552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2552 followup putting the subtitles in the title links This should be the correct package, minus the bit about boraccount. Also added the barcodes to the barcode column, with notes about which are item level and which are title level. This should be the correct-est patch of any I've sent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2533|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2551|0 |1 is patch| | Attachment #2551|0 |1 is obsolete| | Attachment #2551|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2533|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|chris@bigballofwax.co.nz |wizzyrea@gmail.com --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2010-12-13 17:26:33 UTC --- Looks like the fix requires both attachment 2533 and attachment 2552. After testing with both of those I can confirm the holds queue list shows subtitles. However, attachment 2533 includes some changes to addbiblio.tmpl which don't belong. Liz, can you send a single revised patch? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-14 00:23:46 UTC --- New patch has been sent, awaiting sign off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #13 from Liz Rea <wizzyrea@gmail.com> 2010-12-14 17:18:34 UTC --- Created attachment 2843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2843 Final squashed patch for this issue. Please test and sign off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2533|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2552|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #14 from Nicole C. Engard <nengard@gmail.com> 2010-12-14 19:02:49 UTC --- I tried to test and sign off - but got a failed message. This could be my fault, so I'm sharing here in case I did something wrong. nengard@debian:~/kohaclone$ git am -3 -i -u bug5143.patch Commit Body is: -------------------------- Potential fix for 5143, now with IE debug removed Need to set up keyword to marc mappings for subtitle, parts, numbers for this to work Squashed commit of the following: commit 555e8a872408371ca9e730b41a61d4fdbb897d51 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Wed Aug 18 21:52:32 2010 +1200 Removing IE debug commit 11df1c363af3fe660e25fb1b18885d205137adb4 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Wed Aug 18 09:52:31 2010 +1200 Final fix for this bug 5143 commit efbb69d898c07332404d6ca906f801ad7ae89707 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Wed Aug 18 09:40:09 2010 +1200 Typo fix commit 0b9423ab3910138e561d73e63190a2a51c7bb603 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Wed Aug 18 09:36:47 2010 +1200 Bug 5143, adding subtile, parts and numbers to the holdsqueue report [Bug 5143] Subtitles not showing on view-holdsqueue.pl Seeking sign off. adds: - the subtitles into the title link (originally Chris Cormack) - barcodes for every listed hold - denoted which items were only item and which could be filled by any item on that bib. - added id's to every column for ease of jquery suppression of data (example: publication data or patron column could be suppressed) [bug 5143] Fixing whitespace errors. More whitespace corrections -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Potential fix for 5143, now with IE debug removed Need to set up keyword to marc mappings for subtitle, parts, numbers for this to work fatal: corrupt patch at line 11 Patch failed at 0001. When you have resolved this problem run "git-am -i -3 --resolved". If you would prefer to skip this patch, instead run "git-am -i -3 --skip". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2843|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> 2010-12-14 19:10:47 UTC --- Created attachment 2846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2846 Revised fix Nicole: I couldn't apply it either, but using the patch on the mailing list worked. I made some suggested minor changes which could use another set of eyes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2846|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> 2010-12-14 19:21:44 UTC --- Created attachment 2847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2847 Revised revised fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-14 20:34:19 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Patch Status|Patch Pushed |Signed Off Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #18 from Liz Rea <wizzyrea@gmail.com> 2010-12-16 16:43:27 UTC --- Works! (In reply to comment #17)
Pushed to master, please test
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Patch Status|Patch Pushed |Needs Signoff Resolution|FIXED | --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-16 20:03:43 UTC --- New patch was sent with help files, needs signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff --- Comment #20 from Nicole C. Engard <nengard@gmail.com> 2010-12-17 23:20:25 UTC --- signed off on help file changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-20 13:55:01 UTC --- New help files pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 --- Comment #22 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-05 23:21:40 UTC --- This bug is mentioned in: [Bug 5143] Adding help text to point users to add keyword to MARC mappings for subtitle fields. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013388.... Bug 5143: Help file revisions per Owen Leonard http://lists.koha-community.org/pipermail/koha-patches/2010-December/013424.... [Bug 5143] Help file revisions per Owen Leonard http://lists.koha-community.org/pipermail/koha-patches/2010-December/013414.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org