[Bug 22237] New: Subscriptions are not linked to Mana upon edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Bug ID: 22237 Summary: Subscriptions are not linked to Mana upon edit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Web services Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 17047 Target Milestone: --- When a new subscription is created using data from Mana, a mana_id value is added to the subscription table. In Serials.pm ModSubscription was not modified to include mana_id, so subscription edits do not correctly link to Mana. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84533&action=edit Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 [Bug 22250] Clean up Mana KB integration with serials and reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Bug 22237 depends on bug 17047, which changed state. Bug 17047 Summary: Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84533|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86028&action=edit Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- How can I find an existing pattern on Mana for testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #3)
How can I find an existing pattern on Mana for testing?
Hi Katrin, you can find subscriptions using subscriptions mana search from main serial module page - it could be accessed from left menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86028|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 86575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86575&action=edit Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug on enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org