[Bug 20148] New: Adding same user multiple times to acq basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Bug ID: 20148 Summary: Adding same user multiple times to acq basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 71273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71273&action=edit Bug 20148: Adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71273|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 71862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71862&action=edit Bug 20148: Adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71862|0 |1 is obsolete| | --- Comment #3 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 71863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71863&action=edit Bug 20148: Adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71863|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71898&action=edit Bug 20148: Adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71898|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71899&action=edit Bug 20148: Prevent adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi paxed, thx for the bug fix! Please make sure your patch subject describes the change (see https://wiki.koha-community.org/wiki/Commit_messages). I've amended it a little to do that. I am going to file another bug for adding users to get notified on receive - same problem there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding same user multiple |Don't allow adding same |times to acq basket |user multiple times to an | |acq basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20237 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Summary|Don't allow adding same |Don't allow adding same |user multiple times to an |user multiple times to a |acq basket |basket or an order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71915&action=edit Bug 20148: Prevent adding same user multiple times to an order Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 20237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org