[Bug 15602] New: Accessibility: Can't tab to add link in patron card creator add patrons popup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Bug ID: 15602 Summary: Accessibility: Can't tab to add link in patron card creator add patrons popup Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/patroncards/add_user_search.pl OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, indradg@gmail.com, katrin.fischer@bsz-bw.de, kyle.m.hall@gmail.com, testopia@bugs.koha-community.org In the patron card creator, patrons are added to a batch from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Add" link. I assume this is because, like the problem in Bug 14193, the link has no href attribute. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15603 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15604 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15605 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 natasha <tasham_8@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tasham_8@hotmail.com Assignee|gmcharlt@gmail.com |tasham_8@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 natasha <tasham_8@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 --- Comment #1 from natasha <tasham_8@hotmail.com> --- Created attachment 46976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46976&action=edit Bug 15602 - Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |In Discussion --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- I got this error: Software error: Can't call method "get_attr" without a package or object reference at /home/koha/kohaclone/patroncards/edit-batch.pl line 137. But isn't your patch the problem here! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Héctor Eduardo Castro Avalos from comment #2)
I got this error:
Software error:
Can't call method "get_attr" without a package or object reference at /home/koha/kohaclone/patroncards/edit-batch.pl line 137.
But isn't your patch the problem here!
Ok the error is lauched when NO LIBRARY IS SET, i.e., when you're using the koha db admin user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46976|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47140&action=edit [SIGNED-OFF]Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47140|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47160&action=edit Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47161&action=edit Bug 15602: Remove cursor:pointer With the href attribute, the cusor will be displayed as a pointer. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org