https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121746&action=edit Bug 28534: Fix engine for pending_offline_circulations table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I wasn't sure how to test this (using koha-testing-docker), but thought that this would work: 1. Check table structure in the database: . koha-mysql kohadev . show create table pending_offline_operations; . should show as "..ENGINE=MyISAM..." 2. Apply patch 3. Update the database (updatedatabase) 4. Check the table structure as per step 1 - should show as "..ENGINE=INNODB.." It does update if I do a reset_all, but for the existing installations I seem to be missing something... (restarting the container didn't work for me - docker restart koha_db_1)? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Nind from comment #2)

I wasn't sure how to test this (using koha-testing-docker), but thought that this would work:

1. Check table structure in the database: . koha-mysql kohadev . show create table pending_offline_operations; . should show as "..ENGINE=MyISAM..." 2. Apply patch 3. Update the database (updatedatabase) 4. Check the table structure as per step 1 - should show as "..ENGINE=INNODB.."

It does update if I do a reset_all, but for the existing installations I seem to be missing something... (restarting the container didn't work for me - docker restart koha_db_1)?

I added an atomic update to fix existing installs. I added a create table as well, one of our sites did not have MyISAM enabled, so the table was not created. To test: 1 - Check current table structure 2 - Apply patch 3 - Update database 4 - Confirm table structure is correct 5 - Drop the table 'DROP TABLE pending_offline_operations' 6 - Update database 7 - Confirm table is created 8 - reset_all 9 - Check the structure and confirm table is created as InnoDB -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121746|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 121917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121917&action=edit Bug 28534: Fix engine for pending_offline_circulations table Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the database release notes| |structure for the | |pending_offline_operations | |table so that it uses the | |InnoDB engine instead of | |the MyISAM engine. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121918|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 123113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123113&action=edit Bug 28534: Atomic update to fix existing installs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124865&action=edit Bug 28534: (follow-up) Don't adjust original DB update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)

1. I would not modify the old DB rev

2. There was a comment about that prior to commit 8c5845ef9ecd92584723cd60a221ecd4710a2516 Bug 26947: Update kohastructure.sql

-- this table is MyISAM, InnoDB tables are growing only and this table is filled/emptied/filled/emptied... -- so MyISAM is better in this case

tmp_holdsqueue is constantly filled/emptied and is InnoDB and has no issues It seems the other problem of InnoDB is the resetting of auto_increment on a restart, which we have handled and should not affect here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #13)

So can we just obsolete those two patches? Let me know when this is ready for QA.

I think all three are needed. The first one fixes the koha structure file, the second one fixes existing installs, and the third one reverts the changes in the first patch to the original db update that creates the table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123113|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125266&action=edit Bug 28534: Atomic update to fix existing installs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work, Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.