[Bug 21232] New: Problems when linking a subscription to a non-existing biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Bug ID: 21232 Summary: Problems when linking a subscription to a non-existing biblionumber Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Appeared in 16.11, for retesting in newer versions: 1) Create a new subscription, for biblionumber enter a numberic high value not existing in your database as a valid biblionumber 2) Verify that you can save (bug 1) 3) Edit the subscription (will show with empty title in search) 4) Correct the link to the record with an existing biblionumber 5) Verify that now the title displays correctly and link to the record works 6) Check "OPAC view" link, it will still show the wrong biblionumber value, leading to nowhere (bug 2) Reason: the biblionumber in subscriptionhistory hasn't been updated 7) Check the serial table for your subscription id: there is still the wrong value (bug 3) I feel like at least the expected issue should have been updated to the correct biblionumber. I am not sure if it could make sense to keep the old one for received issues, to keep some history of name changes etc. Maybe worth checking if the serial.biblionumber is used somewhere in a sensible way? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20351 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Certainly a duplicate of bug 20351. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #1)
Certainly a duplicate of bug 20351.
On first glance, I don't think it is. It's catching invalid subscriptionids, while this is about an invalid biblionumber? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updating to master, there is still no check in place for linking subscriptions to non-existing biblionumbers. I think this should be checked on saving or maybe even when moving from the first part of the subscription form to the second -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ztajoli@gmail.com --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12921 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Now failing with Can't call method "title" on an undefined value at /home/vagrant/kohaclone/Koha/Subscription.pm line 165 Koha::Subscription::get_sharable_info('Koha::Subscription', 1) called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123 Koha::SharedContent::prepare_entity_data('', 51, 1, 'subscription') called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 82 Koha::SharedContent::send_entity('', 51, 1, 'subscription') called at /home/vagrant/kohaclone/serials/subscription-add.pl line 376 CGI::Compile::ROOT::home_vagrant_kohaclone_serials_subscription_2dadd_2epl::redirect_add_subscription at /home/vagrant/kohaclone/serials/subscription-add.pl line 178 It's time to add the missing FK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5)
Now failing with
Can't call method "title" on an undefined value at /home/vagrant/kohaclone/Koha/Subscription.pm line 165 Koha::Subscription::get_sharable_info('Koha::Subscription', 1) called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123 Koha::SharedContent::prepare_entity_data('', 51, 1, 'subscription') called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 82 Koha::SharedContent::send_entity('', 51, 1, 'subscription') called at /home/vagrant/kohaclone/serials/subscription-add.pl line 376
CGI::Compile::ROOT::home_vagrant_kohaclone_serials_subscription_2dadd_2epl:: redirect_add_subscription at /home/vagrant/kohaclone/serials/subscription-add.pl line 178
It's time to add the missing FK
After bug 22849 the subscription will be created without warning/error and inserted with an invalid biblionumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89357&action=edit Bug 21232: Add a client-side check on biblionumber when creating a subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)
Created attachment 89357 [details] [review] Bug 21232: Add a client-side check on biblionumber when creating a subscription
Something like that could work, but much more is missing: - JS code is horrible there - Biblio's title could be retrieved and displayed - server-side code is missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89357|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96245&action=edit Bug 21232: Add a client-side check on biblionumber when creating a subscription This patch adds an AJAX call to the REST API (/api/v1/biblios/) to retrieve and display the biblio's title. On clicking the "next" button a check is done to make sure the title exists, which means the biblionumber we manually entered is valid (can we assume a title is mandatory?) Test plan: - Create or edit a new subscription - Enter an invalid biblionumber in the input => A friendly note is telling you that the biblio does not exist - Try to switch to the next screen => You get an alert - Enter a valid biblionumber in the input => The title is displayed => Try to switch to the next screen => It works! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23677 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96245|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96489&action=edit Bug 21232: Add a client-side check on biblionumber when creating a subscription This patch adds an AJAX call to the REST API (/api/v1/biblios/) to retrieve and display the biblio's title. On clicking the "next" button a check is done to make sure the title exists, which means the biblionumber we manually entered is valid (can we assume a title is mandatory?) Test plan: - Create or edit a new subscription - Enter an invalid biblionumber in the input => A friendly note is telling you that the biblio does not exist - Try to switch to the next screen => You get an alert - Enter a valid biblionumber in the input => The title is displayed => Try to switch to the next screen => It works! Signed-off-by: hc <hc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96489|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96576&action=edit Bug 21232: Add a client-side check on biblionumber when creating a subscription This patch adds an AJAX call to the REST API (/api/v1/biblios/) to retrieve and display the biblio's title. On clicking the "next" button a check is done to make sure the title exists, which means the biblionumber we manually entered is valid (can we assume a title is mandatory?) Test plan: - Create or edit a new subscription - Enter an invalid biblionumber in the input => A friendly note is telling you that the biblio does not exist - Try to switch to the next screen => You get an alert - Enter a valid biblionumber in the input => The title is displayed => Try to switch to the next screen => It works! Signed-off-by: hc <hc@interleaf.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- I've been attempting to push this to 19.11.x and I can apply the patch, but it does not perform as expected. I am not warned that my biblionumber is invalid. I'm not stopped from completing the addition of the serial linked to a 'bad' bibnumber. Any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- Must have been a cache issue. A bit of playing with FF and the settings and few hard cache clears and all's well. It's working now. :) joy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 96576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96576 Bug 21232: Add a client-side check on biblionumber when creating a subscription Review of attachment 96576: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21232&attachment=96576) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/subscription-add.js @@ +60,5 @@
}
+ var bib_exists = $("input[name='title']").val().length; + + if (!bib_exists) alert(_("Bibliographic record does not exist!"));
This won't translate - got missed before. Can we fix it in a follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24358 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #16)
Comment on attachment 96576 [details] [review] Bug 21232: Add a client-side check on biblionumber when creating a subscription
Review of attachment 96576 [details] [review]: -----------------------------------------------------------------
::: koha-tmpl/intranet-tmpl/prog/js/subscription-add.js @@ +60,5 @@
}
+ var bib_exists = $("input[name='title']").val().length; + + if (!bib_exists) alert(_("Bibliographic record does not exist!"));
This won't translate - got missed before. Can we fix it in a follow-up?
Sorry about that, see bug 24358. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 [Bug 24358] "Bibliographic record does not exist!" is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #18 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Is this a candidate to be backported to 18.11.x? I am testing this at the moment, and each existing biblionumber I put in the Record field I get the 'This bibliographic record does not exist' message and and blocked from going to the next page. Can anyone think of any reason the API call would be failing for me? I may be missing something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Hayley Mapley from comment #18)
Is this a candidate to be backported to 18.11.x?
I am testing this at the moment, and each existing biblionumber I put in the Record field I get the 'This bibliographic record does not exist' message and and blocked from going to the next page.
Can anyone think of any reason the API call would be failing for me? I may be missing something.
Hi Hayley, the API routes for biblios do not exist in 18.11 (added by bug 23677). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #20)
backported to 19.05.x for 19.05.07
Hi Luke, it looks like the dependency is not in 19.05 - did you test if this works? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 [Bug 23677] Add API route to get a bibliographic record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #22 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Thanks Jonathan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Kait, Im sorry, I am missing that dependency. I have reverted this patch set. This is NOT in 19.05.x Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org