[Bug 18775] New: The "Password Reset" notice should use the patron' s homebranch's email as "from" address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Bug ID: 18775 Summary: The "Password Reset" notice should use the patron's homebranch's email as "from" address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: techservspec@gmail.com QA Contact: testopia@bugs.koha-community.org The password reset notice currently uses the email address stored in the KohaAdminEmailAddress system preference as the "from" address. This can be confusing to patrons (or even make them suspicious) since it may not be the same address (or even the same domain) as the rest of their email notices. This enhancement would use the "from" address set for the patron's home branch and only use the Koha Admin Email Address as a fallback if there is not an address set for the home branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 --- Comment #1 from David Kuhn <techservspec@gmail.com> --- Created attachment 64173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64173&action=edit Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18570 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jessica <jessicafreeman@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jessica <jessicafreeman@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64173|0 |1 is obsolete| | --- Comment #2 from Jessica <jessicafreeman@catalyst.net.nz> --- Created attachment 64875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64875&action=edit Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender. Signed-off-by: Jessica Freeman <jessicafreeman@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64875|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65024&action=edit Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender. Signed-off-by: Jessica Freeman <jessicafreeman@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65025&action=edit Bug 18775: Use Koha::Patron->library instead of Koha::Libraries->find Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18988 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think we should really use Koha::Email here to have the same logic as other emails. There is another related bug 18988, also commenting there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #7)
Hm, I think we should really use Koha::Email here to have the same logic as other emails. There is another related bug 18988, also commenting there.
Sigh - after looking at the code more closely, that is nonsense. The password reset emails are using the message_queue which makes them work just like they should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 VikDC <delcastillovictorandres@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |delcastillovictorandres@gma | |il.com Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #9 from VikDC <delcastillovictorandres@gmail.com> --- hi, i've made all set that you guys mentioned there but i can't make it work, if i use this command: "echo "TEST MAIL" | mail -s "Email test subject" myemail@domain.com" I got email in my account gmail, but when i try to use "forgotten password" koha (opac) says that i'll recieve an email, but i got nothing, i hope you can help me, i have more than a week trying to make it work, thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- VikDC: This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org