http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10997 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 21848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21848&action=edit Bug 11004 - Make xmlControlfield.js use the marcflavour syspref to look for XML files Currently, xmlControlfield.js is hard coded to look for XML files for MARC21: url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml", This patch makes this code use the value from the marcflavour syspref, as a preparation for making the NORMARC value builders use the XML technique employed by the MARC21 value builders for 006 and 008. To test: - Make sure you have a MARC21 installation - Set marcflavour = NORMARC - Go to Cataloguing and start a new record with the default framework - Open the value builders for 006 and 008 and observe that they still work, showing the coded values for MARC21 - Apply this patch - Check the value builders for 006 and 008 and observe that you get a truncated view with an empty "Select a type of material" dropdown - Use e.g. the Net console in Firebug to observe requests to http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml that result in a 404 status - Set marcflavour = MARC21 - Observe that the value builders for 006 and 008 are now fully working - 006 and 008 should be the only value builders affected by this change, since they are the only ones using xmlControlfield.js, but please also verify that other value builders are still working as expected -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-28 last check this| | --- Comment #3 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21848|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23796&action=edit Bug 11004 - Make xmlControlfield.js use the marcflavour syspref to look for XML files Currently, xmlControlfield.js is hard coded to look for XML files for MARC21: url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml", This patch makes this code use the value from the marcflavour syspref, as a preparation for making the NORMARC value builders use the XML technique employed by the MARC21 value builders for 006 and 008. To test: - Make sure you have a MARC21 installation - Set marcflavour = NORMARC - Go to Cataloguing and start a new record with the default framework - Open the value builders for 006 and 008 and observe that they still work, showing the coded values for MARC21 - Apply this patch - Check the value builders for 006 and 008 and observe that you get a truncated view with an empty "Select a type of material" dropdown - Use e.g. the Net console in Firebug to observe requests to http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml that result in a 404 status - Set marcflavour = MARC21 - Observe that the value builders for 006 and 008 are now fully working - 006 and 008 should be the only value builders affected by this change, since they are the only ones using xmlControlfield.js, but please also verify that other value builders are still working as expected Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23796|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23806&action=edit Bug 11004 - Make xmlControlfield.js use the marcflavour syspref to look for XML files Currently, xmlControlfield.js is hard coded to look for XML files for MARC21: url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml", This patch makes this code use the value from the marcflavour syspref, as a preparation for making the NORMARC value builders use the XML technique employed by the MARC21 value builders for 006 and 008. To test: - Make sure you have a MARC21 installation - Set marcflavour = NORMARC - Go to Cataloguing and start a new record with the default framework - Open the value builders for 006 and 008 and observe that they still work, showing the coded values for MARC21 - Apply this patch - Check the value builders for 006 and 008 and observe that you get a truncated view with an empty "Select a type of material" dropdown - Use e.g. the Net console in Firebug to observe requests to http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml that result in a 404 status - Set marcflavour = MARC21 - Observe that the value builders for 006 and 008 are now fully working - 006 and 008 should be the only value builders affected by this change, since they are the only ones using xmlControlfield.js, but please also verify that other value builders are still working as expected Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.