[Bug 30095] New: Allow to change "warn when late" setting in subscriptions batch modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Bug ID: 30095 Summary: Allow to change "warn when late" setting in subscriptions batch modification tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 29996 Bug 29996 adds a "warn when late" setting for subscriptions. This bug is for being able to modify this setting in the subscriptions batch modification tool. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996 [Bug 29996] Show an alert on main page when serial issues are late -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 130549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130549&action=edit Bug 30095: Add "warn when late" to subscriptions batch mod tool This patch depends on bug 29996 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Warn when late" column 4. Submit the form without changing anything. Verify that the setting "warn when late" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the form. Verify that the setting "warn when late" was changed to "No" for all selected subscriptions 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the form. Verify that the setting "warn when late" was changed to "Yes" for all selected subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Julian Maurice from comment #1)
Created attachment 130549 [details] [review] Bug 30095: Add "warn when late" to subscriptions batch mod tool
This patch depends on bug 29996
Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Warn when late" column 4. Submit the form without changing anything. Verify that the setting "warn when late" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the form. Verify that the setting "warn when late" was changed to "No" for all selected subscriptions 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the form. Verify that the setting "warn when late" was changed to "Yes" for all selected subscriptions
Received the error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.librarian' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 96 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- My apologies - this is the correct error code received when applying the patch: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt line 327: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130549|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175386&action=edit Bug 30095: Add "warn when late" to subscriptions batch mod tool This patch depends on bug 29996 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Warn when late" column 4. Submit the form without changing anything. Verify that the setting "warn when late" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the form. Verify that the setting "warn when late" was changed to "No" for all selected subscriptions 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the form. Verify that the setting "warn when late" was changed to "Yes" for all selected subscriptions Sponsored-by: Écoles Nationales Supérieures d'Architecture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased (In reply to Laura Escamilla from comment #3)
My apologies - this is the correct error code received when applying the patch:
Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt line 327: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127
This patch doesn't touch intranet-main.tt so this error must come from elsewhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175386|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 183389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183389&action=edit Bug 30095: Add "warn when late" to subscriptions batch mod tool This patch depends on bug 29996 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Warn when late" column 4. Submit the form without changing anything. Verify that the setting "warn when late" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the form. Verify that the setting "warn when late" was changed to "No" for all selected subscriptions 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the form. Verify that the setting "warn when late" was changed to "Yes" for all selected subscriptions Sponsored-by: Écoles Nationales Supérieures d'Architecture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Automated patch testing results: [PASS] ALL PATCHES APPLY CLEANLY All patches apply successfully to the current codebase. **Patch Results:** [PASS] Bug-30095-Add-warn-when-late-to-subscriptions-batc.patch (ID: 183389) Status: SUCCESS Dependencies applied: 29996 + Patch applies cleanly **Dependencies:** 29996 --- This is an automated message from the patch testing system. Tested against branch: main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it looks like git-bz will ignore the dependency when the status is "Patch doesn't apply". But we'll need the change to the start page for this to make sense first, so setting to BLOCKED for now. For later: The current label text is: "Warn when late" - I wonder if an additional hint that this concerns the information shown on the start page of Koha would be helpful here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is also impacted by Bug 30096 Add "late issue notification" to subscriptions batch mod tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30096 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org