[Bug 43458] New: Inconsistent link/button for restrictions and overdues on the circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 Bug ID: 43458 Summary: Inconsistent link/button for restrictions and overdues on the circulation page Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- If you have overdues and restrictions for a patrons, the screen looks like this: https://snipboard.io/JsH4OZ.jpg "View restrictions" is a button Then Overdues: Patron has ITEMS OVERDUE "See highlighted items below" With "See highlighted items below" is a link to view the checkouts Then "Override restriction temporarily" is a button. It's not consistent. My suggestion would be to have "View restrictions" with a link. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43318 [Bug 43318] Remove event attributes from patron_messages.inc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204880&action=edit Bug 43458: Make "View restrictions" match "See highlighted items below" link style If you have overdues and restrictions for a patrons, the screen looks like this: https://snipboard.io/JsH4OZ.jpg "View restrictions" is a button Then Overdues: Patron has ITEMS OVERDUE "See highlighted items below" With "See highlighted items below" is a link to view the checkouts Then "Override restriction temporarily" is a button. It's not consistent. My suggestion would be to have "View restrictions" with a link. Test plan: Have an overdue and a restriction for a patron, go to their circulation page and confirm that the style of messages are more consistent with this patch applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I've signed off, as I'm all for consistency! However, if a patron has overdue charges, they have similar buttons as well: "Make payment", and "Pay all charges". Personally, I think I like the buttons as it is easier to see at a glance. If they were all buttons then I think they should be: - View restrictions (because there can be multiple restrictions, then it can't come at the end of the sentence like the others) - View overdue items (or View overdues) - Make payment Pay all charges -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 204951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204951&action=edit Bug 43458: Make "View restrictions" match "See highlighted items below" link style If you have overdues and restrictions for a patrons, the screen looks like this: https://snipboard.io/JsH4OZ.jpg "View restrictions" is a button Then Overdues: Patron has ITEMS OVERDUE "See highlighted items below" With "See highlighted items below" is a link to view the checkouts Then "Override restriction temporarily" is a button. It's not consistent. My suggestion would be to have "View restrictions" with a link. Test plan: Have an overdue and a restriction for a patron, go to their circulation page and confirm that the style of messages are more consistent with this patch applied Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206254&action=edit Bug 43458: Make "View restrictions" match "See highlighted items below" link style If you have overdues and restrictions for a patrons, the screen looks like this: https://snipboard.io/JsH4OZ.jpg "View restrictions" is a button Then Overdues: Patron has ITEMS OVERDUE "See highlighted items below" With "See highlighted items below" is a link to view the checkouts Then "Override restriction temporarily" is a button. It's not consistent. My suggestion would be to have "View restrictions" with a link. Test plan: Have an overdue and a restriction for a patron, go to their circulation page and confirm that the style of messages are more consistent with this patch applied Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- QA'd successfully. Tested with a patron with overdue items and restrictions. Confirmed that "View restrictions" is now displayed as a link, consistent with "See highlighted items below." Confirmed that the "View restrictions" link still works as expected and displays the patron's restrictions. Also checked the other actions in the patron messages area and did not find any regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43458 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED CC| |pedro.amorim@openfifth.co.u | |k --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Removing this from the queue as it currently depends on a FQA bug. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org