[Bug 31828] New: Add page-section to list of open invoices on receive shipment page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Bug ID: 31828 Summary: Add page-section to list of open invoices on receive shipment page (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/parcels.pl?booksellerid=1 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 Blocks: 31757 When receiving a shipment and you have existing open invoices for this vendor, they show in a list above the form for entering the new invoice number. This area needs a page-section. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Staff Client |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143524&action=edit Bug 31828: Add page-section to list of open invoices on receive shipment page (acq) This patch adds a "page-section" class to the div wrapping the table of shipments on the "Receive shipment" page in Acquisitions. This patch also modifies the markup around additional fields so that an empty fieldset is not displayed when there are no additional fields to display. To test, apply the patch and go to Acquisitions. - Locate a vendor and view its details. - In the toolbar, click "Receive shipments." - On the receive page, there should be a section listing shipments and a section headed "Receive a new shipment." - If you have additional fields defined (in Administration -> Additional fields -> Invoices) there should be a third section showing those fields. - With no additional fields defined you should not see an empty fieldset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143524|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143593&action=edit Bug 31828: Add page-section to list of open invoices on receive shipment page (acq) This patch adds a "page-section" class to the div wrapping the table of shipments on the "Receive shipment" page in Acquisitions. This patch also modifies the markup around additional fields so that an empty fieldset is not displayed when there are no additional fields to display. To test, apply the patch and go to Acquisitions. - Locate a vendor and view its details. - In the toolbar, click "Receive shipments." - On the receive page, there should be a section listing shipments and a section headed "Receive a new shipment." - If you have additional fields defined (in Administration -> Additional fields -> Invoices) there should be a third section showing those fields. - With no additional fields defined you should not see an empty fieldset. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143593|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143604&action=edit Bug 31828: Add page-section to list of open invoices on receive shipment page (acq) This patch adds a "page-section" class to the div wrapping the table of shipments on the "Receive shipment" page in Acquisitions. This patch also modifies the markup around additional fields so that an empty fieldset is not displayed when there are no additional fields to display. To test, apply the patch and go to Acquisitions. - Locate a vendor and view its details. - In the toolbar, click "Receive shipments." - On the receive page, there should be a section listing shipments and a section headed "Receive a new shipment." - If you have additional fields defined (in Administration -> Additional fields -> Invoices) there should be a third section showing those fields. - With no additional fields defined you should not see an empty fieldset. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Bug 31828 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org