[Bug 22844] New: Simplify the process of selecting database columns for system preferences

newer
[Bug 32721] New: Allow UserCSS and...

older
[Bug 28561] New: Order_by triggers...

bugzilla-daemon＠bugs.koha-community.org

3 May 2019 3 May '19

8:01 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Bug ID: 22844 Summary: Simplify the process of selecting database columns for system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- Created attachment 89322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89322&action=edit Screenshot showing column selection in a modal window Right now the process of hand-typing the names of database columns in system preferences like BorrowerMandatoryField is cumbersome and error-prone. I would like to change to a system where the user can select from a predefined list of database columns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

3 May 3 May

8:53 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:53 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89323&action=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs ("Secondary email": "emailpro") for database columns which are relevant to preferences which reference borrower table columns. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

8:55 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

8:55 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

6 May 6 May

8:08 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

8:08 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89389&action=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs for database columns which are relevant to preferences which reference borrower table columns. My intention was to have user-friendly values as the labels, but embedding English strings in JSON would make them untranslatable. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

7 May 7 May

4:38 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

4:38 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89389|0 |1 is obsolete| | --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 89403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89403&action=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs for database columns which are relevant to preferences which reference borrower table columns. My intention was to have user-friendly values as the labels, but embedding English strings in JSON would make them untranslatable. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

Owen, did you investigate columns.def?

Good point, but no blocker for me at feature freeze date. We probably should merge these things. Note that the items columns are no longer up to date in columns.def; see also 22867. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:56 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #8)

...

(In reply to Jonathan Druart from comment #5)

...
Owen, did you investigate columns.def?

Good point, but no blocker for me at feature freeze date. We probably should merge these things.

I did investigate columns.def but I was looking for a solution which wouldn't require an additional script for converting columns.def into something which could be easily parsed by JavaScript. A unified solution would certainly be preferable. Do we need a script which has the ability to output JSON? Or would it be better to use JSON everywhere and modify the translation process to include JSON? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:26 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick note while testing: the "Save all XXX preferences" buttons do not behave correctly. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:49 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Actually there is something weird in master as well, the buttons are not disabled when clicked. Sounds like a regression, isn't it? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate CC| |nick@bywatersolutions.com --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- I ran out of time for testing etc today, but this seems a culmination of a lot of work we have done on improving this interface this cycle, I would like to include it if we can resolve issues in the next few days -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 May 11 May

4:30 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #12)

...

I ran out of time for testing etc today, but this seems a culmination of a lot of work we have done on improving this interface this cycle, I would like to include it if we can resolve issues in the next few days

We can push it and fix later, issues are minors. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 May 13 May

7:56 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

14 May 14 May

4:49 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 210 $(".modalselect").on("click", function(){ Should be .preference I think. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:51 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89749&action=edit Bug 22844: POC - Add patron attributes to the list TODO: - Handle 'checked' flag - Update code in memberentry.tt -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:52 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- IMO This is not ready for 19.05.00, could be part of 19.05.01 however. Letting the decision to RM. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

15 May 15 May

7:17 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_05_candidate | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- I really like these, would like to see Joubu's patches tested so holding off for 19.05 One note too: With this patch I cannot see the full value of the pref or copy the text of the pref out - it would be nice to have the helper and also be able to directly edit the field. Not a blocker -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 May 17 May

4:07 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

4:48 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

4:50 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728 [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 May 22 May

4:23 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #18)

...

One note too: With this patch I cannot see the full value of the pref or copy the text of the pref out - it would be nice to have the helper and also be able to directly edit the field. Not a blocker

+1 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:25 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #23)

...

Or wait for a more complete and tested approach :) (I personally vote for the later)

+1 too -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Jun 6 Jun

6:37 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This introduces JSON files to the /preferences directory.. as such we'll need to update xt/yaml_valid.t to be a little more intelligent. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Jun 7 Jun

8:53 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90407&action=edit Bug 22844: (QA follow-up) Build items.json for UniqueItemFields Adding items.json, built from latest kohastructure.sql. Control UniqueItemFields with this source file. And add StatisticsFields. Test plan: Go to Preferences, play with UniqueItemFields. Adjust StatisticsFields and look at patron record, statistics tab. Moved-from: Bug 22867 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:56 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22867 | Depends on| |22867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 [Bug 22867] UniqueItemFields preference value should be pipe-delimited -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:04 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:30 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It feels like we're starting to mix concerns a bit here. I would suggest splitting the `BorrowerMandatoryField` handling back out of this bug and putting it in bug 22728 and letting this bug start moving forward again. Perhaps we could add the free text box itself into the bottom of the modal and track it's content to match the checkbox selection with some clever JS? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Jun 20 Jun

2:18 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 [Bug 23124] trailing spaces in DefaultPatronSearchFields can break patron searching -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Oct 1 Oct

8:59 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #28)

...

I would suggest splitting the `BorrowerMandatoryField` handling back out of this bug

So: I modify my original patch and remove the changes which modify the behavior of the BorrowerMandatoryField field and make the other patches obsolete.

...

Perhaps we could add the free text box itself into the bottom of the modal

Is there any reason to do so in this patch if we're not concerned about patron attributes? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Nov 1 Nov

7:51 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5 Dec 5 Dec

11:28 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96007&action=edit Bug 22844: (follow-up) Make the attribute mandatory when editing a patron Previous patch forgot the most important, adding the required attribute to the select/textarea -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:29 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

30 Jan 30 Jan

11:07 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:07 a.m.

bugzilla-daemon＠bugs.koha-community.org

20 Mar 20 Mar

3:25 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

6:35 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101198|0 |1 is obsolete| | Attachment #101199|0 |1 is obsolete| | Attachment #101200|0 |1 is obsolete| | Attachment #101201|0 |1 is obsolete| | Attachment #101202|0 |1 is obsolete| | Attachment #101203|0 |1 is obsolete| | Attachment #101204|0 |1 is obsolete| | Attachment #101205|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101302&action=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs for database columns which are relevant to preferences which reference borrower table columns. My intention was to have user-friendly values as the labels, but embedding English strings in JSON would make them untranslatable. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Mar 23 Mar

Just a couple of things from running through the testing again:

0) The mandatorty fields for self registration and editing worked for me!

The patron's attributes? Not that's not possible it worked before the last patch (from today). The "usual" mandatory fields worked, yes.

...

1) The image attached to the bug shows the human readable field name then the system field name in brackets. With the patches only the system field name is shown. Not a show stopper to get this really nice feature into the next release, but from a 'user' perspective having it the way in the image looks much nicer to me.

You should regenerate the css file with `yarn build css`.

...

2) These system preferences need the text removed about separating the columns with an |: - BorrowerUnwantedField (separate columns with |) - PatronQuickAddFields (separate columns with |)

Indeed, I will attach a follow-up later. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:17 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- David, reading the last comments I noticed it may not be obvious: This patch set has been delayed because of the patron's attributes. In current master there is a hidden feature: you can insert patron's attribute codes in the syspref, and it makes the patron's attribute mandatory in the form. With only the first patches (and the pref), we dropped this feature: only the fields from the borrowers table were displayed. With the next iteration we add the ability to define a patron's attribute mandatory (on the edit form of the patron's attribute). The last patch should make the mandatory patron's attributes mandatory at the OPAC (self-registration and modification). Let me know if you have any questions! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Apr 29 Apr

6:18 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

...

...
1) The image attached to the bug shows the human readable field name then the system field name in brackets. With the patches only the system field name is shown. Not a show stopper to get this really nice feature into the next release, but from a 'user' perspective having it the way in the image looks much nicer to me.

Jonathan:

...

You should regenerate the css file with `yarn build css`.

I'm also getting only the system field name. Not a show stopper IMHO. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:38 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103904&action=edit Bug 22844: Remove 'separate columns with |' from prefs description -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:38 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #96 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #94)

...

David:

...
...
1) The image attached to the bug shows the human readable field name then the system field name in brackets. With the patches only the system field name is shown. Not a show stopper to get this really nice feature into the next release, but from a 'user' perspective having it the way in the image looks much nicer to me.

Jonathan:

...
You should regenerate the css file with `yarn build css`.

I'm also getting only the system field name.

Not a show stopper IMHO.

I read too quickly, that's the expected behaviour indeed. Could be improved later if needed. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:36 p.m.

6:43 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

...

- apply the patches - regenerate the staff client CSS (yarn build) - updatedatabase - dbic - flush_memcached - restart_all to make sure the updated .pref file is used

-- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:47 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #108 from David Nind <david@davidnind.com> --- Hi Jonathan and Victor. Apologies for the delay in replying - it got crazy busy at work in the last day or so. Thanks for the follow-up patch for the system preference text. I had regenerated the CSS, so the change was displaying correctly. What I was trying to say was it looked nicer showing the field label with the field name in brackets after it (as per the original screenshot), but that it wasn't a show stopper and doing that latter is fine. For making patron attributes mandatory in self registration, I used the wrong term I think. I only tried making standard patron fields mandatory for self registration and editing - which worked as expected. I hadn't tried with custom patron attributes. Glad to see it is now signed off, as it is a really nice feature! David -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 May 18 May

11:57 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:15 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

5 Jul 5 Jul

12:59 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:59 p.m.

bugzilla-daemon＠bugs.koha-community.org

7:25 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Jul 8 Jul

6:09 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Jul 17 Jul

7:31 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Jul 19 Jul

5:08 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Jul 20 Jul

9:36 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #121 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, can you confirm you have tested mandatory patron's attributes? See comment 93. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:49 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #122 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #121)

...

Katrin, can you confirm you have tested mandatory patron's attributes? See comment 93.

I believe I did, but it's been too long now. Do you have a specific case you need tested? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:44 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I listed some ideas in comment 80. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:47 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

5:47 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #124 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Jul 21 Jul

9:48 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107126&action=edit Bug 22844: Fix yaml_valid.t - don't pick .json files Only .pref are considered yaml files. kohadev-koha@kohadevbox:/kohadevbox/koha$ time prove xt/yaml_valid.t xt/yaml_valid.t .. 1/19 # Failed test 'borrowers.json is YAML' # at xt/yaml_valid.t line 39. # Failed test 'items.json is YAML' # at xt/yaml_valid.t line 39. # Looks like you failed 2 tests of 19. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:24 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #126 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Follow-up pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Jul 25 Jul

8:31 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #127 from Lucas Gass <lucas@bywatersolutions.com> --- Not backporting this enhancement to 20.05.x series. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Jul 28 Jul

10:37 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

30 Aug 30 Aug

9:24 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 [Bug 26283] dateexpiry and dateenrolled are missing in the new modal for BorrowerMandatoryField and others -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Sep 24 Sep

6:06 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Sep 29 Sep

3:33 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26566 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Oct 14 Oct

4:56 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

6 Nov 6 Nov

12:23 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Dec 17 Dec

4:53 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Jan 22 Jan

12:58 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23410 CC| |andrew.isherwood@ptfs-europ | |e.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 [Bug 23410] Add submenus to system preferences sidebar menu -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:59 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Jan 25 Jan

12:18 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Apr 27 Apr

1:58 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Sep 1 Sep

11:01 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28392 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392 [Bug 28392] streettype and B_streettype cannot be hidden via BorrowerUnwantedField -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:26 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

bugzilla-daemon＠bugs.koha-community.org

2:51 p.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936 [Bug 28936] Sort1 and Sort2 should be included in BorrowerUnwantedField and related sysprefs -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 May 22 May

10:01 a.m.

New subject: [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 [Bug 36816] OPAC - Patron 'submit update request' does not work for clearing patron attribute types -- You are receiving this mail because: You are watching all bug changes.

784

Age (days ago)

2630

Last active (days ago)

List overview

Download

170 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org