http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9726 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15754|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16431&action=edit [SIGNED-OFF] Bug 9726: XISBN service throttle not initialized For limiting XISBN API use, XISBNDailyLimit syspref is used to compare with daily use count of the API. This count is stored in services_throttle table. But this table content is never initialized, not in installer nor in updatedatabase. So count is never increased and API is used without limit. This patch add an insert of service type in services_throttle if not existing. So service throttle will be initialized. Test plan : - Check that you don't have a line in services_throttle for service_type=xisbn - Activate FRBRizeEditions and XISBN sysprefs - Set a small number in XISBNDailyLimit (ie 5) - Go to a biblio page (with ISBN) - Look at services_throttle table => you should have a line for service_type=xisbn with service_count=1. - Refresh biblio page untill limit is reached => service_count should be equal to limit for service_type=xisbn Signed-off-by: Owen Leonard <oleonard@myacpl.org> Passes test plan correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16431|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17063&action=edit [PASSED QA] Bug 9726: XISBN service throttle not initialized For limiting XISBN API use, XISBNDailyLimit syspref is used to compare with daily use count of the API. This count is stored in services_throttle table. But this table content is never initialized, not in installer nor in updatedatabase. So count is never increased and API is used without limit. This patch add an insert of service type in services_throttle if not existing. So service throttle will be initialized. Test plan : - Check that you don't have a line in services_throttle for service_type=xisbn - Activate FRBRizeEditions and XISBN sysprefs - Set a small number in XISBNDailyLimit (ie 5) - Go to a biblio page (with ISBN) - Look at services_throttle table => you should have a line for service_type=xisbn with service_count=1. - Refresh biblio page untill limit is reached => service_count should be equal to limit for service_type=xisbn Signed-off-by: Owen Leonard <oleonard@myacpl.org> Passes test plan correctly. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Fixes problem, tested according to test plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9726 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 -- You are receiving this mail because: You are watching all bug changes.