[Bug 32046] New: When adding a new records from a staged files, there are style issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Bug ID: 32046 Summary: When adding a new records from a staged files, there are style issues Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id =2&basketno=1&booksellerid=1 OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 To test: * Create order * Stage file of MARC records * Order from staged file * Select file -> now you are on the right page listing records Found issues: - Toolbar has a shadow and background color? - Labels and pulldowns/checkboxes are misaligned - Item form layout on Item tab is broken! - counting information tab: Statistics fields are misaligned - can't save due to JS erorr, filed separately as: bug 32045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143258&action=edit Proposed layout change How does this look as an alternative layout? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The layout would work for me - maybe some more white background? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, will you have time for this one? I could try to have a go at the misaligned statistics and the item form (looking at the other places we fixed them) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143952&action=edit Bug 32046: When adding a new records from a staged files, there are style issues This patch modifies the template for adding a record from a staged file in order to resolve some layout problems introduced by the staff redesign. This patch also corrects an problem with addorderiso2709.js: It included some template markup. The template variables are converted to a JS variable to prevent a JS error. Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>. To test you must have at least one MARC file staged for import. - Apply the patch and go to Acquisitions. - Locate a vendor and create a basket if necessary. - Add to the basket and choose the option of adding an order from a staged file. - Click "Add orders" next to one of the staged files. - On the Add orders from MARC file page, test that everything looks correct and works correctly: - In the first tab, expanding and collapsing order details by checking the checkbox or clicking the title. - Test the "MARC" and "Card" preview buttons. - Under the Item information tab, confirm that the layout looks correct and that the form works correctly, including plugin operations like auto barcode fill. - Test that, under the Default accounting details tab, changing the fund automatically sets the fund for each title in the first tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32231 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32231 [Bug 32231] Improve display of items, when items are created from staged files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143952|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143956&action=edit Bug 32046: When adding a new records from a staged files, there are style issues This patch modifies the template for adding a record from a staged file in order to resolve some layout problems introduced by the staff redesign. This patch also corrects an problem with addorderiso2709.js: It included some template markup. The template variables are converted to a JS variable to prevent a JS error. Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>. To test you must have at least one MARC file staged for import. - Apply the patch and go to Acquisitions. - Locate a vendor and create a basket if necessary. - Add to the basket and choose the option of adding an order from a staged file. - Click "Add orders" next to one of the staged files. - On the Add orders from MARC file page, test that everything looks correct and works correctly: - In the first tab, expanding and collapsing order details by checking the checkbox or clicking the title. - Test the "MARC" and "Card" preview buttons. - Under the Item information tab, confirm that the layout looks correct and that the form works correctly, including plugin operations like auto barcode fill. - Test that, under the Default accounting details tab, changing the fund automatically sets the fund for each title in the first tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143958&action=edit Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- I think I tested this correctly, but have a couple of comments: 1. Could we make an exception to the add/edit item form so that the width for form labels is wider? In my view, making it narrow and then wrapping the text: - makes it harder to read/scan - makes the input field height longer - which makes the alignment for the tick boxes and RegEx links look "weird" (Batch item modification form) - particularly when there is enough space on the page, even for smaller screen widths 2. For the acquisition screens, I wasn't sure why on these that the dropdown lists have a grey background. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The first tab looks great now, the third tab too, but I got some issues with the item form: https://snipboard.io/QHUtIW.jpg The longer descriptions now blow up the input fields, this was not the case in previous iterations. In general I'd love if we could give labels more space in multiple locations. We always need to add additional CSS there for German and I'd so love to get rid of it. Also the problem seems prominent now also for the English templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Great minds think alike ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143958|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143996&action=edit Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143996|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143997&action=edit Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, conflicts... :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143956|0 |1 is obsolete| | Attachment #143997|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144022&action=edit Bug 32046: When adding a new records from a staged files, there are style issues This patch modifies the template for adding a record from a staged file in order to resolve some layout problems introduced by the staff redesign. This patch also corrects an problem with addorderiso2709.js: It included some template markup. The template variables are converted to a JS variable to prevent a JS error. Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>. To test you must have at least one MARC file staged for import. - Apply the patch and go to Acquisitions. - Locate a vendor and create a basket if necessary. - Add to the basket and choose the option of adding an order from a staged file. - Click "Add orders" next to one of the staged files. - On the Add orders from MARC file page, test that everything looks correct and works correctly: - In the first tab, expanding and collapsing order details by checking the checkbox or clicking the title. - Test the "MARC" and "Card" preview buttons. - Under the Item information tab, confirm that the layout looks correct and that the form works correctly, including plugin operations like auto barcode fill. - Test that, under the Default accounting details tab, changing the fund automatically sets the fund for each title in the first tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144023&action=edit Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144022|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144027&action=edit Bug 32046: When adding a new records from a staged files, there are style issues This patch modifies the template for adding a record from a staged file in order to resolve some layout problems introduced by the staff redesign. This patch also corrects an problem with addorderiso2709.js: It included some template markup. The template variables are converted to a JS variable to prevent a JS error. Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>. To test you must have at least one MARC file staged for import. - Apply the patch and go to Acquisitions. - Locate a vendor and create a basket if necessary. - Add to the basket and choose the option of adding an order from a staged file. - Click "Add orders" next to one of the staged files. - On the Add orders from MARC file page, test that everything looks correct and works correctly: - In the first tab, expanding and collapsing order details by checking the checkbox or clicking the title. - Test the "MARC" and "Card" preview buttons. - Under the Item information tab, confirm that the layout looks correct and that the form works correctly, including plugin operations like auto barcode fill. - Test that, under the Default accounting details tab, changing the fund automatically sets the fund for each title in the first tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144023|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144028&action=edit Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 32235 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt OK filters OK forbidden patterns OK git manipulation FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's a false positive, I checked with Owen when I signed off and he also noted in the commit:
Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Ah, I see: [%# As long as cataloging plugins rely on 'script' tags added inline, JS must be in the header %] <script> const template_path = "[% interface | html %]/[% theme | html %]"; </script> Katrin: You switched status. But you did not add signoff lines ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Actually, there are such large changes in a template that I cant oversee if we somewhere add string changes at this time before release.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #21)
Actually, there are such large changes in a template that I cant oversee if we somewhere add string changes at this time before release..
Ah, will fix. It's my usual mistake when I forget to git stash the yarn. The git so then fails a bit too silently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144027|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144052&action=edit Bug 32046: When adding a new records from a staged files, there are style issues This patch modifies the template for adding a record from a staged file in order to resolve some layout problems introduced by the staff redesign. This patch also corrects an problem with addorderiso2709.js: It included some template markup. The template variables are converted to a JS variable to prevent a JS error. Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>. To test you must have at least one MARC file staged for import. - Apply the patch and go to Acquisitions. - Locate a vendor and create a basket if necessary. - Add to the basket and choose the option of adding an order from a staged file. - Click "Add orders" next to one of the staged files. - On the Add orders from MARC file page, test that everything looks correct and works correctly: - In the first tab, expanding and collapsing order details by checking the checkbox or clicking the title. - Test the "MARC" and "Card" preview buttons. - Under the Item information tab, confirm that the layout looks correct and that the form works correctly, including plugin operations like auto barcode fill. - Test that, under the Default accounting details tab, changing the fund automatically sets the fund for each title in the first tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144028|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144053&action=edit Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144052|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144193&action=edit Bug 32046: When adding a new records from a staged files, there are style issues This patch modifies the template for adding a record from a staged file in order to resolve some layout problems introduced by the staff redesign. This patch also corrects an problem with addorderiso2709.js: It included some template markup. The template variables are converted to a JS variable to prevent a JS error. Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>. To test you must have at least one MARC file staged for import. - Apply the patch and go to Acquisitions. - Locate a vendor and create a basket if necessary. - Add to the basket and choose the option of adding an order from a staged file. - Click "Add orders" next to one of the staged files. - On the Add orders from MARC file page, test that everything looks correct and works correctly: - In the first tab, expanding and collapsing order details by checking the checkbox or clicking the title. - Test the "MARC" and "Card" preview buttons. - Under the Item information tab, confirm that the layout looks correct and that the form works correctly, including plugin operations like auto barcode fill. - Test that, under the Default accounting details tab, changing the fund automatically sets the fund for each title in the first tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144053|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144194&action=edit Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, QA scripts generally happy and all works as expected. Passing QA. Warning: This patch does introduce two new strings as far as I can tell, labels only. I'll leave it to RM's discretion whether as a major it's worth the pain or not to push now or just after 22.11.00 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Bug 32046 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org