[Bug 9658] New: Breadcrumb wrong on reports dictionary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Bug ID: 9658 Summary: Breadcrumb wrong on reports dictionary Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jcamins@cpbibliography.com CC: gmcharlt@gmail.com The breadcrumb on the reports dictionary looks like this: Home › Reports › Guided reports wizard Dictionary (without the small arrow, and with dictionary bolded) rather than like this, the way it should: Home › Reports › Guided reports wizard › Dictionary -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jcamins@cpbibliography.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 15499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15499&action=edit Bug 9658: Incorrect breadcrumb on report dictionary Prior to this patch, the breadcrumb on the reports dictionary looks like this: Home > Reports > Guided reports wizard Dictionary (notice the lack of punctuation between "wizard" and "Dictionary"). This patch makes it consistent with the rest of the system so it looks like this: Home > Reports > Guided reports wizard > Dictionary I left dictionary bolded, since that seems to have been intentional, even if I can't find a good reason for it. To test: 1) View reports dictionary page before and after patch is applied, observing difference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15499|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15501&action=edit [SIGNED-OFF] Bug 9658: Incorrect breadcrumb on report dictionary Prior to this patch, the breadcrumb on the reports dictionary looks like this: Home > Reports > Guided reports wizard Dictionary (notice the lack of punctuation between "wizard" and "Dictionary"). This patch makes it consistent with the rest of the system so it looks like this: Home > Reports > Guided reports wizard > Dictionary I left dictionary bolded, since that seems to have been intentional, even if I can't find a good reason for it. To test: 1) View reports dictionary page before and after patch is applied, observing difference. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Trivial patch. Work as described. No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Works as expected. Simple patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15501|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15526&action=edit Bug 9658: Incorrect breadcrumb on report dictionary Prior to this patch, the breadcrumb on the reports dictionary looks like this: Home > Reports > Guided reports wizard Dictionary (notice the lack of punctuation between "wizard" and "Dictionary"). This patch makes it consistent with the rest of the system so it looks like this: Home > Reports > Guided reports wizard > Dictionary I left dictionary bolded, since that seems to have been intentional, even if I can't find a good reason for it. To test: 1) View reports dictionary page before and after patch is applied, observing difference. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Trivial patch. Work as described. No errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9658 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org