[Bug 12609] New: Replace use of DBI in C4::Ratings with DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Bug ID: 12609 Summary: Replace use of DBI in C4::Ratings with DBIx::Class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org We should replace the use of DBI in C4::Ratings with DBIC instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29846&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29846|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29847&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29847|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29848&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29848|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29849&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12608 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29849|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31293&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31294&action=edit Bug 12609: Add some unit tests for C4::Ratings Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31293|0 |1 is obsolete| | Attachment #31294|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31449&action=edit [PASSED QA] Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Also tested: - Adding a rating - Rating displayed on detail - Rating displayed on results - Modifying a rating - Change displayed correctly on detail and results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31450&action=edit [PASSED QA] Bug 12609: Add some unit tests for C4::Ratings Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #9)
Patches pushed to master.
Thanks Kyle and Jonathan!
This breaks opac-ratings-ajax.pl: opac-ratings-ajax.pl: Can't locate object method "new" via package "Koha::Database" (perhaps you forgot to load "Koha::Database"?) at /home/koha/src/C4/Ratings.pm line 206. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13998 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to Tomás Cohen Arazi from comment #9)
Patches pushed to master.
Thanks Kyle and Jonathan!
This breaks opac-ratings-ajax.pl: opac-ratings-ajax.pl: Can't locate object method "new" via package "Koha::Database" (perhaps you forgot to load "Koha::Database"?) at /home/koha/src/C4/Ratings.pm line 206.
Actually it's not introduced by this patch, the issue does not exist on 3.18.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org